Repository navigation
Fix documentation and site accessibility findings (#264-#268) - #271
Merged
Merged
Conversation
…o its label Remove outline: none from the .quick-jumps-list a:focus rule so the site-wide a:focus-visible outline (2px solid, blue) applies to the Quick Jumps links again (WCAG 2.4.7 Focus Visible). Hover still underlines the link; the dark-mode and high-contrast rules only change colors and do not remove the outline. Remove aria-label="Search documentation" from the site-search input on every page and on the search page, so the field takes its accessible name, "Search docs", from its label, which matches the visible placeholder (WCAG 2.5.3 Label in Name). Regenerated html/ with npm run build:html. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PmRBrUTuhzYnQBFxUCN6Vr
Emoji (172 findings, four admin guides):
- FACILITATOR_GUIDE.md and FACILITATOR_RESOURCES.md: remove the emoji
from every heading, from running text and from the Section-Level
Source Maps. Update every link to the changed anchors in both files
and in admin/README.md (#-github-classroom-setup-before-day-1 becomes
#github-classroom-setup-before-day-1, and so on). Describe the pencil
icon by its button name, "Edit this file", instead of an emoji.
- Point the guide's broken in-page link to a nonexistent
"Troubleshooting GitHub Classroom Setup" heading at "Known Gotchas",
the section directly below it.
- FACILITATOR_OPERATIONS.md: remove the emoji from the sample chat
messages and the narrated demo script.
- CURRICULUM_2.0_ORGANIZATION.md: replace each check mark with the word
it stood for ("Complete", "Yes") or drop it from lists whose heading
already says the items are done.
Code block languages (88 findings, 34 files): add a language to every
fenced code block that had none: bash for shell commands, bat for the
Windows batch files, markdown for Markdown source, and text for output,
file trees, conflict examples, sample messages and keystroke steps.
Nothing inside any block changed.
Heading: give admin/classroom admin access.md a title and a sentence of
context.
The documentation check now reports 3 findings, all the deliberate
"bad example" links in Appendix C; the baseline shrinks from 264 to 3.
Regenerated html/ with npm run build:html.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PmRBrUTuhzYnQBFxUCN6Vr
Contributor
Peer Review AssignedHi @accesswatch! Your PR has been automatically paired with @taylorarndt for peer review. For @taylorarndt:This is a great opportunity to practice code review skills! Here's what to look for: Content Quality:
Accessibility:
Documentation:
Review Guidelines:
Resources: Pairing by Learning Room Grouping Engine |
This was referenced Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two commits.
1. Site template (
scripts/build-html.js, regeneratedhtml/)outline: nonefrom.quick-jumps-list a:focus, so the site-widea:focus-visibleoutline (2px solid #0969da; #58a6ff in dark mode, white in high contrast) applies again. Hover still underlines the link. The dark-mode and high-contrast rules for Quick Jumps change only colors, so nothing removes the outline again.html/styles/custom.cssloses that one line.aria-label="Search documentation"from thesite-searchinput in both templates (every page, and the search page). The field now takes its name from<label for="site-search">Search docs</label>, which matches the start of its visible placeholder, "Search docs…". 217 pages regenerate with only that line removed.Not yet checked in a browser or with a screen reader. This environment could not download a browser, so the changes were checked against the CSS cascade and the generated markup only. #265 and #266 stay open until someone confirms them by hand: Tab to a Quick Jumps link in light and dark mode and look for the blue outline, and Tab to the search box with a screen reader and listen for "Search docs".
2. Documentation accessibility findings (Markdown, regenerated
html/, baseline)admin/FACILITATOR_GUIDE.md,admin/FACILITATOR_RESOURCES.md,admin/FACILITATOR_OPERATIONS.mdandadmin/CURRICULUM_2.0_ORGANIZATION.md, covering headings, running text and the Section-Level Source Maps. Where an emoji meant something, a word replaces it: the check marks became "Complete" or "Yes", and the pencil emoji became the button's name, "Edit this file". Every link to a changed anchor is updated in the two guides and inadmin/README.md(14 cross-file and 5 in-page links). One in-page link that was already broken, to a heading "Troubleshooting GitHub Classroom Setup" that does not exist, now points to "Known Gotchas", the section directly below it. All 230 anchor links in the five regenerated admin pages resolve.bashfor shell commands,batfor the Windows batch files,markdownfor Markdown source andtextfor output, file trees, conflict examples, sample messages and keystroke steps. Only the opening fence lines changed; the contents of the blocks did not.admin/classroom admin access.mdnow has a title and one sentence of context.Checks
node scripts/check-docs-accessibility.js: 264 findings before, 3 after. The baseline shrinks to match. The 3 left are the deliberate "bad example" links in the link-text table ofdocs/appendix-c-markdown-reference.md.npm run validate:authoritative-sources: passes (174 files).npm run test:automation: 105 passing.html/register.htmlfrom the Linux build is not committed.Not in scope, found along the way
admin/FACILITATOR_CLASSROOM_TROUBLESHOOTING.mdis linked from four admin guides, but it is not in the repository. Only a stalehtml/admin/FACILITATOR_CLASSROOM_TROUBLESHOOTING.htmlexists, so those links work on the site only through that leftover page.Fixes #264
Fixes #267
Fixes #268
Refs #265
Refs #266
https://claude.ai/code/session_01PmRBrUTuhzYnQBFxUCN6Vr
Generated by Claude Code