Repository navigation
fix(site): text contrast in dark mode and code highlighting - #274
Merged
Merged
Conversation
A contrast scan of every page in light and dark mode found text under 4.5:1: in dark mode the breadcrumb, footer and all code blocks (the light highlight theme was used on a dark background, down to 1.18:1), and in light mode the orange, green and red highlight colours on the code background (3.28:1 to 4.3:1). Code blocks now use GitHub's dark highlight theme in dark mode, the four short colours are replaced with GitHub's own shades of the same hue, and the breadcrumb and footer get dark-mode colours. A re-scan of all 223 pages finds nothing under 4.5:1 in either mode. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PmRBrUTuhzYnQBFxUCN6Vr
Contributor
Peer Review AssignedHi @accesswatch! Your PR has been automatically paired with @taylorarndt for peer review. For @taylorarndt:This is a great opportunity to practice code review skills! Here's what to look for: Content Quality:
Accessibility:
Documentation:
Review Guidelines:
Resources: Pairing by Learning Room Grouping Engine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A contrast scan of the live site (every text element against its real background, in light and dark mode) found text below WCAG 1.4.3's 4.5:1:
Fix, in
scripts/build-html.js: code blocks use GitHub's dark highlight theme in dark mode; the four short colours are replaced with GitHub's own shades of the same hue (#953800, #116329, #cf222e, and #58a6ff in dark); the breadcrumb and footer get dark-mode colours. Onlyhtml/styles/changes.Verified: a re-scan of all 223 site pages with Playwright, in light and dark mode, finds nothing under 4.5:1.
Generated by Claude Code