Skip to content

fix(site): text contrast in dark mode and code highlighting #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
accesswatch merged 1 commit into from
Oct 28, 2026
Merged

fix(site): text contrast in dark mode and code highlighting #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions html/styles/custom.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,8 @@
}

@media (prefers-color-scheme: dark) {
.breadcrumb { color: #9198a1; }
.breadcrumb a { color: #58a6ff; }
.site-header { background: #0d1117; border-bottom-color: #30363d; }
.search-input { background: #161b22; border-color: #30363d; color: #e6edf3; }
.search-input:focus { border-color: #58a6ff; box-shadow: 0 0 0 3px rgba(88,166,255,0.3); background: #0d1117; }
Expand Down Expand Up @@ -847,6 +849,11 @@ textarea:focus-visible {
text-decoration: underline;
}

@media (prefers-color-scheme: dark) {
.site-footer { color: #9198a1; border-top-color: #30363d; }
.site-footer a { color: #58a6ff; }
}

/* Reduced motion support */
@media (prefers-reduced-motion: reduce) {
*,
Expand Down
130 changes: 125 additions & 5 deletions html/styles/highlight.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ code.hljs {
.hljs-type,
.hljs-variable.language_ {
/* prettylights-syntax-keyword */
color: #d73a49
color: #cf222e
}
.hljs-title,
.hljs-title.class_,
Expand Down Expand Up @@ -59,7 +59,7 @@ code.hljs {
.hljs-built_in,
.hljs-symbol {
/* prettylights-syntax-variable */
color: #e36209
color: #953800
}
.hljs-comment,
.hljs-code,
Expand All @@ -72,7 +72,7 @@ code.hljs {
.hljs-selector-tag,
.hljs-selector-pseudo {
/* prettylights-syntax-entity-tag */
color: #22863a
color: #116329
}
.hljs-subst {
/* prettylights-syntax-storage-modifier-import */
Expand All @@ -99,7 +99,7 @@ code.hljs {
}
.hljs-addition {
/* prettylights-syntax-markup-inserted */
color: #22863a;
color: #116329;
background-color: #f0fff4
}
.hljs-deletion {
Expand All @@ -115,4 +115,124 @@ code.hljs {
.hljs-tag {
/* purposely ignored */

}
}
@media (prefers-color-scheme: dark) {
pre code.hljs {
display: block;
overflow-x: auto;
padding: 1em
}
code.hljs {
padding: 3px 5px
}
/*!
Theme: GitHub Dark
Description: Dark theme as seen on github.com
Author: github.com
Maintainer: @Hirse
Updated: 2021-05-15

Outdated base version: https://github.com/primer/github-syntax-dark
Current colors taken from GitHub's CSS
*/
.hljs {
color: #c9d1d9;
background: #0d1117
}
.hljs-doctag,
.hljs-keyword,
.hljs-meta .hljs-keyword,
.hljs-template-tag,
.hljs-template-variable,
.hljs-type,
.hljs-variable.language_ {
/* prettylights-syntax-keyword */
color: #ff7b72
}
.hljs-title,
.hljs-title.class_,
.hljs-title.class_.inherited__,
.hljs-title.function_ {
/* prettylights-syntax-entity */
color: #d2a8ff
}
.hljs-attr,
.hljs-attribute,
.hljs-literal,
.hljs-meta,
.hljs-number,
.hljs-operator,
.hljs-variable,
.hljs-selector-attr,
.hljs-selector-class,
.hljs-selector-id {
/* prettylights-syntax-constant */
color: #79c0ff
}
.hljs-regexp,
.hljs-string,
.hljs-meta .hljs-string {
/* prettylights-syntax-string */
color: #a5d6ff
}
.hljs-built_in,
.hljs-symbol {
/* prettylights-syntax-variable */
color: #ffa657
}
.hljs-comment,
.hljs-code,
.hljs-formula {
/* prettylights-syntax-comment */
color: #8b949e
}
.hljs-name,
.hljs-quote,
.hljs-selector-tag,
.hljs-selector-pseudo {
/* prettylights-syntax-entity-tag */
color: #7ee787
}
.hljs-subst {
/* prettylights-syntax-storage-modifier-import */
color: #c9d1d9
}
.hljs-section {
/* prettylights-syntax-markup-heading */
color: #58a6ff;
font-weight: bold
}
.hljs-bullet {
/* prettylights-syntax-markup-list */
color: #f2cc60
}
.hljs-emphasis {
/* prettylights-syntax-markup-italic */
color: #c9d1d9;
font-style: italic
}
.hljs-strong {
/* prettylights-syntax-markup-bold */
color: #c9d1d9;
font-weight: bold
}
.hljs-addition {
/* prettylights-syntax-markup-inserted */
color: #aff5b4;
background-color: #033a16
}
.hljs-deletion {
/* prettylights-syntax-markup-deleted */
color: #ffdcd7;
background-color: #67060c
}
.hljs-char.escape_,
.hljs-link,
.hljs-params,
.hljs-property,
.hljs-punctuation,
.hljs-tag {
/* purposely ignored */

}
}
25 changes: 22 additions & 3 deletions scripts/build-html.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -987,9 +987,21 @@ function setupStyles(outputDir) {
const githubCss = require.resolve('github-markdown-css');
fs.copyFileSync(githubCss, path.join(stylesDir, 'github-markdown.css'));

// Copy highlight.js CSS (GitHub theme)
const highlightCss = path.join(require.resolve('highlight.js'), '../../styles/github.css');
fs.copyFileSync(highlightCss, path.join(stylesDir, 'highlight.css'));
// highlight.js CSS: the GitHub light theme, plus GitHub dark for dark mode.
// A few stock colours fall short of WCAG 1.4.3 (4.5:1) on the code block
// background (#f6f8fa light, #151b23 dark), so they are replaced with
// GitHub's own darker or lighter shades of the same hue.
const stylesRoot = path.join(require.resolve('highlight.js'), '../../styles');
const lightCss = fs.readFileSync(path.join(stylesRoot, 'github.css'), 'utf8')
.replace(/color: #e36209/g, 'color: #953800')
.replace(/color: #22863a/g, 'color: #116329')
.replace(/color: #d73a49/g, 'color: #cf222e');
const darkCss = fs.readFileSync(path.join(stylesRoot, 'github-dark.css'), 'utf8')
.replace(/color: #1f6feb/g, 'color: #58a6ff');
fs.writeFileSync(
path.join(stylesDir, 'highlight.css'),
`${lightCss}\n@media (prefers-color-scheme: dark) {\n${darkCss}\n}\n`
);

// Create custom CSS for additional accessibility and styling
const customCss = `
Expand Down Expand Up @@ -1187,6 +1199,8 @@ function setupStyles(outputDir) {
}

@media (prefers-color-scheme: dark) {
.breadcrumb { color: #9198a1; }
.breadcrumb a { color: #58a6ff; }
.site-header { background: #0d1117; border-bottom-color: #30363d; }
.search-input { background: #161b22; border-color: #30363d; color: #e6edf3; }
.search-input:focus { border-color: #58a6ff; box-shadow: 0 0 0 3px rgba(88,166,255,0.3); background: #0d1117; }
Expand Down Expand Up @@ -1841,6 +1855,11 @@ textarea:focus-visible {
text-decoration: underline;
}

@media (prefers-color-scheme: dark) {
.site-footer { color: #9198a1; border-top-color: #30363d; }
.site-footer a { color: #58a6ff; }
}

/* Reduced motion support */
@media (prefers-reduced-motion: reduce) {
*,
Expand Down
Loading