Skip to content
Draft
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions RELEASE_NOTES.md

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the docs need updating too?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated container-apps.md to document all four fields of ServiceBusScaleRule (QueueName, Namespace, MessageCount, SecretRef) (commit 47bfd399).

Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
Release Notes
=============

## 1.9.15
* ACA: Add required namespace field to sbus scale rule

## 1.9.14
* VMSS, AKS, Azure Firewall, Managed Clusters (AKS): Adds `pick_zones` to let ARM select the availability zones.
* AKS: Remove deprecated `docker_bridge` from Container Services (AKS).
Expand Down
1 change: 1 addition & 0 deletions src/Farmer/Arm/App.fs
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,7 @@ type ContainerApp = {
metadata = {|
queueName = settings.QueueName
messageCount = string settings.MessageCount
``namespace`` = settings.Namespace
|}
auth = [|
{|
Expand Down
1 change: 1 addition & 0 deletions src/Farmer/Common.fs
Original file line number Diff line number Diff line change
Expand Up @@ -4026,6 +4026,7 @@ module ContainerApp =

type ServiceBusScaleRule = {
QueueName: string
Namespace: string
MessageCount: int
SecretRef: string
}
Expand Down
1 change: 1 addition & 0 deletions src/Tests/ContainerApps.fs

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should one of the tests check that the value is set correctly?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added assertions to check that queueName, messageCount, and namespace are all correctly serialized in the JSON output (commit 47bfd399).

Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ let fullContainerAppDeployment =
QueueName = "wishrequests"
MessageCount = 5
SecretRef = "servicebusconnectionkey"
Namespace = "servicebus"
}
}
containerApp {
Expand Down