π¨ Palette: μΈλΆ λ§ν¬ μ μ°½ μ΄κΈ° μκ°μ μμ΄μ½ μΆκ° - #101
π¨ Palette: μΈλΆ λ§ν¬ μ μ°½ μ΄κΈ° μκ°μ μμ΄μ½ μΆκ°#101seonghobae wants to merge 1 commit into
Conversation
- `target="_blank"`μΈ λ§ν¬ μμ μ μ°½ μμ΄μ½μ CSSλ‘ μΆκ°νμ¬ μκ°μ μμΈ‘ κ°λ₯μ± ν₯μ - κ΄λ ¨ UX/μ κ·Όμ± νμ΅ λ΄μ©μ .jules/palette.mdμ κΈ°λ‘ - CHANGELOG μ λ°μ΄νΈ
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
Adds a visual βopens in new tab/windowβ indicator for links using target="_blank" to improve user predictability on this static site, implemented purely in CSS (no HTML changes).
Changes:
- Add a
::aftericon (SVG mask) fora[target="_blank"]instyles.css. - Record the user-facing change in
CHANGELOG.md. - Add a palette learning-journal entry (but currently introduces a casing-duplicate file path).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
styles.css |
Adds a masked SVG pseudo-element icon after target="_blank" links. |
CHANGELOG.md |
Documents the new external-link indicator under [Unreleased] (format needs to match existing bullets). |
.jules/palette.md |
Adds a learning entry, but duplicates existing .Jules/palette.md via case-only path difference. |
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| width: 0.8em; | ||
| height: 0.8em; | ||
| margin-left: 0.3em; | ||
| background-color: currentColor; |
| -webkit-mask-size: contain; | ||
| -webkit-mask-repeat: no-repeat; | ||
| mask-image: url("data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24 24' fill='none' stroke='black' stroke-width='2.5' stroke-linecap='round' stroke-linejoin='round'%3E%3Cpath d='M18 13v6a2 2 0 0 1-2 2H5a2 2 0 0 1-2-2V8a2 2 0 0 1 2-2h6'%3E%3C/path%3E%3Cpolyline points='15 3 21 3 21 9'%3E%3C/polyline%3E%3Cline x1='10' y1='14' x2='21' y2='3'%3E%3C/line%3E%3C/svg%3E"); | ||
| mask-size: contain; | ||
| mask-repeat: no-repeat; |
|
|
||
| ### λ³κ²½ μ¬ν | ||
| * `target="_blank"` μΈλΆ λ§ν¬μ μ μ°½ μμ΄μ½ μΆκ°νμ¬ μκ°μ μΈμ§ κ°μ |
| ## 2026-07-23 - μ μ°½μμ μ΄κΈ° λ§ν¬ μΈλμΌμ΄ν° μΆκ° | ||
| **Learning:** νμ΄μ§ λ΄μ `target="_blank"` μμ±μ κ°μ§ μΈλΆ λ§ν¬κ° λ€μ μ‘΄μ¬νμ§λ§, ν΄λ¦ μ μ νμ΄ μ΄λ¦°λ€λ μκ°μ κ²½κ³ λ μλ΄κ° μμμ΅λλ€. μ΄λ μμΈ‘ λΆκ°λ₯ν νμ κ²½νμ μ£Όμ΄ μ¬μ©μμκ² νΌλμ μ΄λν μ μμ΅λλ€. | ||
| **Action:** CSSμ `::after` κ°μ μμμ SVG λ§μ€ν¬λ₯Ό νμ©νμ¬ `target="_blank"` λ§ν¬ μμ μμ 'μ μ°½' μμ΄μ½μ μΆκ°νμ΅λλ€. μ΄λ₯Ό ν΅ν΄ HTML ꡬ쑰λ₯Ό 볡μ‘νκ² λ§λ€μ§ μκ³ λ μ¬μ©μμκ² λͺ νν μκ°μ ννΈλ₯Ό μ 곡νμ¬ μΈμ§ λΆνλ₯Ό μ€μμ΅λλ€. |
|
Closing rather than rebasing this stale branch. Its global |
μ΄ν΄νμ΅λλ€. ν΄λΉ μμ μ΄ λ μ΄μ μ ν¨νμ§ μμμ νμΈνμΌλ©° μμ μ μ€λ¨νκ² μ΅λλ€. |
π‘ What:
target="_blank"μμ±μ κ°μ§ μΈλΆ λ§ν¬ μμ μμ 'μ μ°½' μμ΄μ½μ μΆκ°νμ΅λλ€.π― Why:
μ¬μ©μκ° λ§ν¬λ₯Ό ν΄λ¦νμ λ μμΈ‘νμ§ λͺ»νκ² μ μ°½μ΄ μ΄λ¦¬λ κ²μ λΉνΉμ€λ¬μμ μ€ μ μμ΅λλ€. μκ°μ μΈλμΌμ΄ν°λ₯Ό ν΅ν΄ νμ κ²½νμ κ°μ νκ³ μΈμ§ λΆνλ₯Ό μ€μμ΅λλ€.
πΈ Before/After:
PR μ€ν¬λ¦°μ·κ³Ό λΉλμ€λ₯Ό μ°Έμ‘°νμΈμ. HTMLμ λ³κ²½νμ§ μκ³ CSS
::afterμ SVG λ§μ€ν¬λ§μ μ¬μ©νμ¬ κΉλνκ² κ΅¬ννμ΅λλ€.βΏ Accessibility:
μκ°μ λ¨μλ₯Ό μΆκ°νμ¬ λ§ν¬ λμμ μμΈ‘ κ°λ₯μ±μ λμμ΅λλ€. (WCAG 2.0 SC 3.2.5 κ΄λ ¨). μ€ν¬λ¦° 리λλ 보ν΅
target="_blank"λ₯Ό μ체μ μΌλ‘ μλ €μ£Όμ§λ§, μΈμ§μ μ κ·Όμ± μΈ‘λ©΄μμ λͺ¨λ μ¬μ©μμκ² λμμ΄ λ©λλ€.PR created automatically by Jules for task 5720050565696081532 started by @seonghobae