Skip to content

a11y(external-links): keep localized tooltip supplemental to persistent context - #213

Draft
seonghobae wants to merge 5 commits into
mainfrom
palette-ux-external-links-14500123097687837924
Draft

a11y(external-links): keep localized tooltip supplemental to persistent context#213
seonghobae wants to merge 5 commits into
mainfrom
palette-ux-external-links-14500123097687837924

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Current exact authority

  • protected base: main@8103aad3582a024946b835d7eee858f65339a184
  • exact head: aa1dde72f5091ea2c5e78ebc006776f0c7cf7e7d
  • lifecycle: Draft / localized-title experiment only / persistent accessible context still RED

Valid delta retained

This branch localizes the supplemental title text for every target="_blank" link through the existing KO/EN runtime and preserves rel="noopener noreferrer". The generated .Jules/palette.md repository-wide doctrine was removed in normal descendant aa1dde72...; the file is byte-identical to protected authority. No force push or destructive rebase was used.

Accessibility RED

title / data-i18n-title is not sufficient evidence that a keyboard or screen-reader user receives the new-window context before activation. The current tests only inspect source tokens and do not establish an accessibility-tree description. Therefore this PR must not claim completed screen-reader support.

The overlapping owner lane is #210. Its accepted GREEN must preserve this branch's valid localized supplemental tooltip semantics while adding one reusable persistent programmatic context for every blank-target link (for example a single localized description node referenced with aria-describedby, or equivalent). Locale changes must update the same context rather than append duplicate announcements; blank-target links must retain rel="noopener noreferrer".

#210 may supersede this PR only after the complete valid delta here is present in its exact tree and current-head browser/accessibility evidence is GREEN. Until then both PRs remain open; do not close merely for overlap.

Browser Delivery Gate

Before Ready: keyboard-focus affected links; inspect their computed accessible name/description; switch every currently supported locale and prove one announcement per link; verify desktop/intermediate/mobile layout with no overflow or focus clipping; and capture current-head E2E/screenshot evidence. Static Python/string checks are source evidence only.

Current Delivery Gate: 의도성 PASS / 기능 완전성 FAIL / 콘텐츠 적합성 PASS / 복원력 FAIL / 증거성 FAIL / 고유성 N/A.

The current site runtime remains KO/EN-only and file-bundled; this PR does not expand that architectural debt. The fleet target for KO/EN/JA/ZH/VI/ES/DE/FR is a versioned translation-resource boundary rather than permanently growing a browser-side catalog.

Fresh checks and review must be evaluated on unchanged aa1dde72...; predecessor evidence does not transfer. No Pages publication, browser acceptance, security-vulnerability closure, self-approval, gate weakening, source-neutral retrigger, generated doctrine, force push, or destructive rebase is claimed.

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as draft September 6, 2026 14:13
@seonghobae seonghobae changed the title 🎨 Palette: [UX improvement] 외부 링크 접근성 속성 추가 a11y(external-links): keep localized tooltip supplemental to persistent context Sep 6, 2026
Comment thread tests/test_i18n_ux.py
@@ -0,0 +1,10 @@
"""Test that i18n.js supports data-i18n-title properly."""
from pathlib import Path
import re
@seonghobae seonghobae added enhancement New feature or request priority: medium Normal-priority or P2 work status: draft Draft pull request type: feature New or expanded product capability labels Sep 6, 2026 — with ChatGPT Codex Connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority: medium Normal-priority or P2 work status: draft Draft pull request type: feature New or expanded product capability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant