a11y(external-links): keep localized tooltip supplemental to persistent context - #213
a11y(external-links): keep localized tooltip supplemental to persistent context#213seonghobae wants to merge 5 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| @@ -0,0 +1,10 @@ | |||
| """Test that i18n.js supports data-i18n-title properly.""" | |||
| from pathlib import Path | |||
| import re | |||
Current exact authority
main@8103aad3582a024946b835d7eee858f65339a184aa1dde72f5091ea2c5e78ebc006776f0c7cf7e7dValid delta retained
This branch localizes the supplemental
titletext for everytarget="_blank"link through the existing KO/EN runtime and preservesrel="noopener noreferrer". The generated.Jules/palette.mdrepository-wide doctrine was removed in normal descendantaa1dde72...; the file is byte-identical to protected authority. No force push or destructive rebase was used.Accessibility RED
title/data-i18n-titleis not sufficient evidence that a keyboard or screen-reader user receives the new-window context before activation. The current tests only inspect source tokens and do not establish an accessibility-tree description. Therefore this PR must not claim completed screen-reader support.The overlapping owner lane is #210. Its accepted GREEN must preserve this branch's valid localized supplemental tooltip semantics while adding one reusable persistent programmatic context for every blank-target link (for example a single localized description node referenced with
aria-describedby, or equivalent). Locale changes must update the same context rather than append duplicate announcements; blank-target links must retainrel="noopener noreferrer".#210 may supersede this PR only after the complete valid delta here is present in its exact tree and current-head browser/accessibility evidence is GREEN. Until then both PRs remain open; do not close merely for overlap.
Browser Delivery Gate
Before Ready: keyboard-focus affected links; inspect their computed accessible name/description; switch every currently supported locale and prove one announcement per link; verify desktop/intermediate/mobile layout with no overflow or focus clipping; and capture current-head E2E/screenshot evidence. Static Python/string checks are source evidence only.
Current Delivery Gate: 의도성 PASS / 기능 완전성 FAIL / 콘텐츠 적합성 PASS / 복원력 FAIL / 증거성 FAIL / 고유성 N/A.
The current site runtime remains KO/EN-only and file-bundled; this PR does not expand that architectural debt. The fleet target for KO/EN/JA/ZH/VI/ES/DE/FR is a versioned translation-resource boundary rather than permanently growing a browser-side catalog.
Fresh checks and review must be evaluated on unchanged
aa1dde72...; predecessor evidence does not transfer. No Pages publication, browser acceptance, security-vulnerability closure, self-approval, gate weakening, source-neutral retrigger, generated doctrine, force push, or destructive rebase is claimed.