๐จ Palette: ํฅ์๋ ์นด๋ ๋งํฌ ํด๋ฆญ ์์ญ ์ง์ - #96
๐จ Palette: ํฅ์๋ ์นด๋ ๋งํฌ ํด๋ฆญ ์์ญ ์ง์#96seonghobae wants to merge 1 commit into
Conversation
.project-grid ์์ญ์ ์นด๋ ์ปจํฌ๋ํธ๋ค์์ ํ ์คํธ ๋งํฌ์๋ง ์์กดํ๋ ํด๋ฆญ ์์ญ์ CSS `::after`์ `inset: 0`์ ์ฌ์ฉํ์ฌ ์นด๋ ์ ์ฒด๋ก ํ์ฅํ์ต๋๋ค. ์ด๋ฅผ ํตํด ์ฌ์ฉ์๊ฐ ์ ํํ ํ ์คํธ๋ฅผ ํด๋ฆญํ์ง ์์๋ ํธํ๊ฒ ์ํธ์์ฉํ ์ ์๊ฒ ํ์ฌ ์ ๊ทผ์ฑ๊ณผ ์ฌ์ฉ์ฑ์ ํฌ๊ฒ ๊ฐ์ ํ์ต๋๋ค.
|
๐ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a ๐ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
This PR improves the usability of the โPublic Projectsโ card grid on the static homepage by making the card feel interactive on hover and by expanding the link hit target beyond just the title text.
Changes:
- Add hover elevation (transform + shadow) and stacking (
z-index) to.project-grid article. - Expand the clickable area for
.project-grid h3 avia an absolutely-positioned::afteroverlay. - Document the click-target expansion pattern in
.Jules/palette.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| styles.css | Adds card hover affordance and implements an overlay technique to make the entire card area click through to the project link. |
| .Jules/palette.md | Records the learned pattern for expanding card click targets using ::after + inset: 0. |
๐ก Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .project-grid article:hover { | ||
| transform: translateY(-2px); | ||
| box-shadow: var(--shadow); | ||
| z-index: 1; | ||
| } |
|
Closing as already implemented on |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
๐ก What:
.project-grid article๋ฑ์ ์นด๋ ์ปจํ ์ด๋ ํด๋์ค์position: relative์ hover ์๊ฐ ํจ๊ณผ(transform, box-shadow)๋ฅผ ์ถ๊ฐํ๊ณ ,.project-grid h3 a::after์ ํ์ฅ๋ ์์ญ ์ถ๊ฐ (content: ''; position: absolute; inset: 0; z-index: 1;)๋ฅผ ๊ตฌํํ์ต๋๋ค.๐ฏ Why: ๊ทธ๋ฆฌ๋๋ ๋ฆฌ์คํธ ํ์์ ์นด๋ ์ปดํฌ๋ํธ์์ ๋งํฌ ํ ์คํธ์๋ง ํด๋ฆญ ์ด๋ฒคํธ๋ฅผ ๋ฐ์ธ๋ฉํ๋ฉด, ์ฌ์ฉ์๊ฐ ์ ํํ๊ฒ ํ ์คํธ๋ฅผ ๊ฒจ๋ฅํ์ฌ ํด๋ฆญํด์ผ ํ๋ฏ๋ก ์ฌ์ฉ์ฑ์ด ์ ํ๋ฉ๋๋ค.
๐ธ Before/After: ์ฒจ๋ถ๋ ํ๋ก ํธ์๋ ๊ฒ์ฆ ๊ฒฐ๊ณผ๋ฌผ ์ฐธ๊ณ .
โฟ Accessibility: ๋ง์ฐ์ค ์ฌ์ฉ์, ํฐ์น ์ฌ์ฉ์๊ฐ ์ ํํ๊ฒ ์ข์ ๋งํฌ๋ฅผ ๋๋ฅผ ํ์๊ฐ ์์ด์ง๋ฏ๋ก ์ ๊ทผ์ฑ์ด ํฌ๊ฒ ํฅ์๋ฉ๋๋ค.
PR created automatically by Jules for task 17491996957091820440 started by @seonghobae