docs(architecture): separate TEPP temporal semantics from psychometric kernels - #1716
docs(architecture): separate TEPP temporal semantics from psychometric kernels#1716seonghobae wants to merge 43 commits into
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughChangesTEPP temporal boundary
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: 🔵 Low · up to The PR adds documentation and architecture checks without changing production behavior, but the adapter contract is not explicitly versioned and the checks do not fully enforce policy direction, index alignment, or manifest-level coupling rules. This is a bounded merge-readiness risk that is mergeable with explicit owner follow-up. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
left a comment
There was a problem hiding this comment.
Post-#1496 control-plane wake verification only; this is not an approval. Re-evaluate exact head ce763c49b50a2426b217ab048e4cc0fc6dc0b8fd under the newly landed central pull_request_review dispatch path and preserve current-head evidence.
seonghobae
left a comment
There was a problem hiding this comment.
Exact-current-head review wake for 43ba529c3b2dfa65e430735e5dce8ca9ee4fbe65 after central .github/main@5f81d8e665b7d3f51f379a090e077486dbf548c5 landed the current Strix preflight timeout repair and Noema deleted-file context repair. This is not approval and does not transfer predecessor evidence.
|
Fresh documentation-ownership repair: Exact current head is |
Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Single-writer handoff for |
Refs #565.
Scope
Establish the bounded-context boundary between time-indexed psychometric computation and temporal/event composition without deleting the existing Rust CT-AR Rasch numerical estimand.
fast-mlsirmowns reusable time-indexed psychometric numerical kernels over explicit supplied occasion/time carriers;ARCHITECTURE.md, authoritative PRD/TRD, requirements traceability,AGENTS.md,CLAUDE.md,docs/context-map.md, and the changelog fragment carry the same ownership boundary;Model Specification,Estimation,Scoring,Diagnostics,Simulation-Recovery,Compute Backend, andPublic Binding, and records the ACL/upstream/downstream relationships to TEPP, psychometrics-commons, context-graph-contracts, and enterprise-architecture-core;Public Bindingforbids independent production statistical arithmetic while preserving governed explicit reference/parity calculations used for validation or CPU/GPU parity evidence;docs/README.mdarchitecture index and its architecture-fitness tests bind claims to their intended Markdown sections rather than searching whole-document fragments;joint_map_hierarchical_ctar_rasch,continuous_time_ar1_ou, andctar_phiwhile machine-checking the owner boundary and agent/context-map guidance;No likelihood, gradient, optimizer, state-transition arithmetic, Python production arithmetic, provider integration, dependency, lockfile, workflow, schema, or database code changes in this PR.
Test-first / correction lineage
127eee1fa76eadf79f76c6f37ccaabc5f9c63ecbfirst exposed the missing executable TEPP/fast ownership boundary. Fresh protected-main inspection then found the existing Rust joint-MAP Rasch + continuous-time AR(1)/OU implementation, so the initial over-broad ownership hypothesis was narrowed rather than deleting valid numerical work.43ba529c3b2dfa65e430735e5dce8ca9ee4fbe65established the accepted distinction: temporal/event semantics and composition are TEPP-owned; explicit time-indexed psychometric numerical kernels remain fast-mlsirm-owned.a61ceed6296077fb565d33b34216dbe95817e7bc→ GREEN069c0f7de097533479dad02ca7aa9eee3c78d633aligns authoritative PRD/TRD with that boundary while preserving the existing CT-AR equations.6898da2e8b76b6efec2f9b701564c015dbba91b6→ GREEN46a92673bd590e0cb5c99c16d5d7f5a39c38daaamakes the canonical requirements traceability matrix identify TEPP as temporal/event-composition authority and fast-mlsirm as numerical-kernel authority.a8581471d7062178dac4b678c3761ae666ee285ais closed bycfd6f39b8bc010312972cdd610e35de69de9aa6fand792db95f7e78487ce998003fec6d0438fbb5864b;f877623154f15faa13f33e3797fa282f7d1233e9keeps the changelog fragment current.ac39b45d20a1dfb1a4ab0d2d45507bd774aa301d→ GREENa340859584c856918eb22f050af416d008b9a6ef, withbdc3041c062487e8951937cd5884a5339fceba76recording the addition.2f0482127e1f75311001cc7eff5c43ac4d97d39a→ GREEN2c6b63dcacc5c45bace6c0c3c8d4daadf50573c3;6820ae775cbb415def348818ccaa60a7759073bblinks the active Context Map from the canonical documentation index.6c98b0f1e05bbf4ccf51128f5ed1dd14e9515036, preserving protectedmain@b5a3a0c1057d4b53d7a4bb18e0de69f630c2b45cin ancestry.5870095f18657e36139111e4b95355c0cdbe6a53proved ADR-0007 lacked an in-file executable ownership qualification. GREENe31c81c946c060eecf0f48117d4566315ed132e4makes ADR-0028 authoritative for every temporal statement in that Proposed record;a9d50d831b2813a66a70fbc0f41b731ad008dc04aligns the regression with Markdown clause identity.36452da4f64b46ad9c35c2e5c8c96d0b46e9ce80extended the same test to ADR-0019/0020. GREENbd30a8893aa7cf7470adb08711378765cfc9deb2anda9ad70f36f925781f1091b2f9028b24be7737753explicitly keep event ontology, temporal validity/order, changing-membership history, leakage policy, and temporal/event composition in TEPP while retaining only their stated OLS/discrete-AR and CT-AR Rasch arithmetic in fast-mlsirm.91c6563c2a3c4d8bddd75b94d261d92e864cf97emakes the policy regression insensitive only to Markdown line wrapping, not clause content.fcaeeed79c77a7b00eb8d6c053001c92471c6b6bcorrects the Jeon & Rabe-Hesketh longitudinal-growth citation from an erroneous 2025 advance-publication record to the actual 2016 Psychometrika, 81(3), 830–850 publication, DOI10.1007/s11336-015-9489-2. The bibliographic correction was independently verified against PubMed and changes no ownership or numerical contract.All currently visible predecessor review findings are resolved; predecessor-head check/review evidence is not transferred after source movement.
Context Graph / EA boundary
ContextualWisdomLab/context-graph-contractsandContextualWisdomLab/enterprise-architecture-coreare read-only dependencies under the Context Fabric writer. Their live governance/release/stack state is refetched before integration decisions; open sibling heads are not immutable production contracts and this PR does not write either repository.Architecture/package/backend/toolchain/consumer-lifecycle facts may be projected only through an immutable released versioned Context Assertion / CloudEvent / conformance contract with provenance. Estimator values, latent scores, DIF/fit diagnostics, and scientific-validity evidence are not EA-authoritative facts. At the latest fresh read, neither foreign repository has an immutable GitHub release, so production EA projection remains fail-closed.
CI and Noema follow-up
33757490863failed identically on CPython 3.12 and 3.14:test_agent_guidance_preserves_temporal_and_context_fabric_boundariestreated Markdown line wrapping in both governed agent-guidance files as a policy change. Commit8b0fc04b4c2eee4ee54b74e581d0b626cca634bcrepaired the comparison; follow-up36b0533f90f75e09eb74e8dbe4103e827c7d3c45narrows normalization to newlines so hard-wrapped sentences pass without allowing ownership phrases to span separate paragraphs.7e5b69212eb6146f1b016e466affeabbc5b47931: CPython 3.12 full6765 passed, 17 skipped in 256.30s; CPython 3.14 focused10 passed in 0.11s;git diff --check b5a3a0c1057d4b53d7a4bb18e0de69f630c2b45c...HEADpassed. Commit7e5b69212eb6146f1b016e466affeabbc5b47931removes four pre-existing trailing-whitespace failures from the PR diff without changing policy content.33646974279successfully selected the repository-scoped GitHub App credential and completed the gateway preflight before contextual-orchestrator returned HTTP 500 after 649.5 seconds in the connecting phase with no served model. Credential failure is not the root cause.33757488400also completed credential selection, token minting, sidecar startup, and gateway preflight before the model phase failed with HTTP 502 after 141.0 seconds in the connecting phase with no served model.Current landing authority
main@b5a3a0c1057d4b53d7a4bb18e0de69f630c2b45c;7e5b69212eb6146f1b016e466affeabbc5b47931;8b0fc04b4c2eee4ee54b74e581d0b626cca634bcto7e5b69212eb6146f1b016e466affeabbc5b47931;Landing still requires fresh exact-current required checks, zero valid unresolved review findings, and the qualifying independent approval required by the live protection/ruleset. No self-approval, bypass, force push, gate weakening, or predecessor evidence transfer is authorized.