Skip to content

Chart later numeric report rows - #47

Merged
seonghobae merged 11 commits into
mainfrom
codex/report-chart-later-values
Jul 10, 2026
Merged

Chart later numeric report rows#47
seonghobae merged 11 commits into
mainfrom
codex/report-chart-later-values

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Summary

  • Chart the first available numeric diagnostics rows instead of only checking the first 12 table rows.
  • Preserve the existing empty-chart behavior when no numeric values exist.
  • Add a report regression covering leading blank chart values followed by a chartable row.

Verification

  • py -3.12 -m pytest tests/test_report.py::test_render_table_section_charts_later_numeric_rows -q -> 1 passed
  • py -3.12 -m pytest tests/test_report.py -q -> 10 passed
  • py -3.12 -m pytest -> 75 passed
  • git diff --check -> no whitespace errors

Design Notes

  • Ponytail: one shared renderer fix, no new dependency or reporting surface.
  • Product Design/Figma: avoids a rendered diagnostics section where a chart is missing even though chartable values exist later in the rows. Figma inspection is blocked locally by token_invalidated, so this PR uses the generated HTML report as the visual surface.

Copilot AI review requested due to automatic review settings July 1, 2026 07:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the HTML diagnostics report renderer to build compact bar charts from the first available numeric rows (skipping leading blank/non-numeric rows), rather than only considering the first 12 table rows. This improves report usefulness when early rows are missing values while later rows contain chartable diagnostics.

Changes:

  • Update _bar_chart to collect numeric rows across the full section and then chart the first 12 numeric entries.
  • Add a regression test ensuring a later numeric row still produces a chart even when the first 12 rows are non-numeric.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
python/fast_mlsirm/report.py Adjusts bar chart row selection to skip non-numeric rows and chart the first numeric diagnostics encountered.
tests/test_report.py Adds regression coverage for leading blank chart values followed by a chartable row.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@seonghobae
seonghobae enabled auto-merge July 1, 2026 07:31
@opencode-agent

opencode-agent Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

OpenCode Review Overview

  • Head SHA: e31f5101e0b0d5c882744868e9809667486a8d81
  • Workflow run: 29076448669
  • Workflow attempt: 1
  • Gate result: APPROVE (approval step)

Pull request overview

OpenCode reviewed the current-head bounded evidence and found no blocking issues.

Findings

No blocking findings.

Summary

Approval sufficiency: bounded evidence supplied affirmative approval evidence for changed files, coverage/docstring posture, risk surfaces, and current-head verification; approval is not based merely on the absence of known blockers.
Verification posture: CodeGraph evidence was initialized and bounded current-head evidence reviewed for changed-file evidence including .clusterfuzzlite/Dockerfile, .clusterfuzzlite/build.sh, .clusterfuzzlite/project.yaml, .github/dependabot.yml, .github/workflows/cflite_pr.yml, and 6 more.
Linter/static: workflow/static review evidence is bounded by the current-head GitHub Checks gate and changed-file evidence.
TDD/regression: coverage execution evidence and focused changed hunks were reviewed from bounded-review-evidence.md.
Coverage: coverage execution evidence reports supported repository test suites passed.
Docstring coverage: coverage execution evidence reports configured repository docstring gates passed or docstring coverage was advisory.
DAG: CodeGraph/source-backed behavior map connects .clusterfuzzlite/Dockerfile to the affected review, runtime, or workflow path and required checks.
PoC/execution: coverage-evidence job executed on the current head and reported PASS.
DDD/domain: workflow and repository-governance invariants were reviewed against changed files in bounded evidence.
CDD/context: CodeGraph evidence, changed-file history, and focused hunks were reviewed from bounded-review-evidence.md.
Similar issues: changed-file history evidence was reviewed for comparable local precedents.
Claim/concept check: bounded evidence, repository source, current-head workflow evidence, and, where numeric, scientific, statistical, or literature-backed claims are affected, original-paper/formula evidence and parameter-recovery expectations were used for claims.
Standards search: standards and external-source checks are delegated to configured OpenCode web_search/Context7/DeepWiki sources when applicable; no evidence-backed standards blocker is present in bounded evidence.
Compatibility/convention: changed workflow/script conventions, object naming, and reserved-word safety for schema/API/config/code surfaces were checked in bounded evidence.
Breaking-change/backcompat: deployment evidence and changed-file history were checked for backward-compatibility risk.
Performance: changed surfaces were checked for performance risk in bounded evidence.
Developer experience: changed automation, review, test, setup, and maintenance surfaces were checked for helpful or obstructive DX impact in bounded evidence.
User experience: connected user, operator, API, CLI, documentation, review-comment, status-check, rendering, and workflow-reader behavior was checked for contradictions against code, docs, and tests in bounded evidence.
Visual/DOM: Playwright visual, DOM locator, ARIA snapshot, console, and responsive evidence were checked when a web UI surface was present; for non-web surfaces, API/CLI/log/docs/workflow interaction evidence was reviewed instead.
Accessibility/i18n: accessibility, localization, and human-readable text surfaces were checked where UI, CLI, API message, docs, logs, or review text changed.
Supply-chain/license: dependency, package, model, container, and external-tool changes were checked in bounded evidence.
Packaging: package, build, test, lint, and security contracts were checked in bounded evidence.
Security/privacy: workflow-token, review-gate, and repository-automation security/privacy boundaries were checked in bounded evidence.

  • Result: APPROVE
  • Reason: All tests pass, no blocking issues, and changes improve report functionality.
  • Head SHA: e31f5101e0b0d5c882744868e9809667486a8d81
  • Workflow run: 29076448669
  • Workflow attempt: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (9 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (9 files)"]
  R1 --> V1["required checks"]
  Evidence --> S2["Workflow: cflite_pr.yml"]
  S2 --> I2["GitHub Actions review job"]
  I2 --> R2["Review risk: Workflow: cflite_pr.yml"]
  R2 --> V2["actionlint plus required checks"]
  Evidence --> S3["Test: test_report.py"]
  S3 --> I3["regression suite"]
  I3 --> R3["Review risk: Test: test_report.py"]
  R3 --> V3["targeted test run"]
Loading

opencode-agent[bot]
opencode-agent Bot previously approved these changes Jul 9, 2026

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode reviewed the current-head bounded evidence and found no blocking issues.

Findings

No blocking findings.

Summary

Approval sufficiency: bounded evidence supplied affirmative approval evidence for changed files, coverage/docstring posture, risk surfaces, and current-head verification; approval is not based merely on the absence of known blockers.
Verification posture: CodeGraph evidence was initialized and bounded current-head evidence reviewed for changed-file evidence including python/fast_mlsirm/report.py, tests/test_report.py.
Linter/static: workflow/static review evidence is bounded by the current-head GitHub Checks gate and changed-file evidence.
TDD/regression: coverage execution evidence and focused changed hunks were reviewed from bounded-review-evidence.md.
Coverage: coverage execution evidence reports supported repository test suites passed.
Docstring coverage: coverage execution evidence reports configured repository docstring gates passed or docstring coverage was advisory.
DAG: CodeGraph/source-backed behavior map connects python/fast_mlsirm/report.py to the affected review, runtime, or workflow path and required checks.
PoC/execution: coverage-evidence job executed on the current head and reported PASS.
DDD/domain: workflow and repository-governance invariants were reviewed against changed files in bounded evidence.
CDD/context: CodeGraph evidence, changed-file history, and focused hunks were reviewed from bounded-review-evidence.md.
Similar issues: changed-file history evidence was reviewed for comparable local precedents.
Claim/concept check: bounded evidence, repository source, current-head workflow evidence, and, where numeric, scientific, statistical, or literature-backed claims are affected, original-paper/formula evidence and parameter-recovery expectations were used for claims.
Standards search: standards and external-source checks are delegated to configured OpenCode web_search/Context7/DeepWiki sources when applicable; no evidence-backed standards blocker is present in bounded evidence.
Compatibility/convention: changed workflow/script conventions, object naming, and reserved-word safety for schema/API/config/code surfaces were checked in bounded evidence.
Breaking-change/backcompat: deployment evidence and changed-file history were checked for backward-compatibility risk.
Performance: changed surfaces were checked for performance risk in bounded evidence.
Developer experience: changed automation, review, test, setup, and maintenance surfaces were checked for helpful or obstructive DX impact in bounded evidence.
User experience: connected user, operator, API, CLI, documentation, review-comment, status-check, rendering, and workflow-reader behavior was checked for contradictions against code, docs, and tests in bounded evidence.
Visual/DOM: Playwright visual, DOM locator, ARIA snapshot, console, and responsive evidence were checked when a web UI surface was present; for non-web surfaces, API/CLI/log/docs/workflow interaction evidence was reviewed instead.
Accessibility/i18n: accessibility, localization, and human-readable text surfaces were checked where UI, CLI, API message, docs, logs, or review text changed.
Supply-chain/license: dependency, package, model, container, and external-tool changes were checked in bounded evidence.
Packaging: package, build, test, lint, and security contracts were checked in bounded evidence.
Security/privacy: workflow-token, review-gate, and repository-automation security/privacy boundaries were checked in bounded evidence.

  • Result: APPROVE
  • Reason: The changes correctly implement the intended behavior and include a regression test.
  • Head SHA: 7cf8a6bcd192281caf75b59570d9e2ce54244338
  • Workflow run: 28499800513
  • Workflow attempt: 2

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file: report.py"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file: report.py"]
  R1 --> V1["required checks"]
  Evidence --> S2["Test: test_report.py"]
  S2 --> I2["regression suite"]
  I2 --> R2["Review risk: Test: test_report.py"]
  R2 --> V2["targeted test run"]
Loading

@seonghobae

Copy link
Copy Markdown
Contributor Author

Merge follow-up for the approved-but-not-merged state:

  • Rechecked current head 7cf8a6b: reviewDecision is APPROVED, mergeable is MERGEABLE, review threads are empty, PR-scoped code-scanning alerts are empty, and all checks are green.
  • Direct gh pr merge --merge was rejected by branch policy: the base branch policy prohibits the merge and instructed to use --auto.
  • Re-applied the policy-compliant path with gh pr merge 47 --merge --auto --delete-branch; GitHub accepted it.

No source change needed in this loop; blocker was merge policy automation, not code/test/security failure.

@seonghobae seonghobae closed this Jul 9, 2026
auto-merge was automatically disabled July 9, 2026 09:34

Pull request was closed

@seonghobae seonghobae reopened this Jul 9, 2026
@seonghobae
seonghobae enabled auto-merge July 9, 2026 09:35
@seonghobae

Copy link
Copy Markdown
Contributor Author

Required-workflow refresh done:

  • The old approved PR was blocked because org ruleset required workflows were missing from the old run set, especially Security Scan and Close Empty PR; direct merge was correctly rejected by policy.
  • Closed and immediately reopened the PR to emit the reopened event used by the required central workflows.
  • New current-head queued runs now exist for CI, OpenCode Review, Strix Security Scan, Close Empty PR, PR Review Merge Scheduler, and Security Scan (trivy-fs, osv-scan, dependency-review, scorecard).
  • Re-enabled auto-merge through the policy-compliant path.

No source change was needed; this was an old-PR required-workflow freshness issue.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Refreshing required workflow events again: the PR is approved and mergeable, but the current required workflow set is stuck on non-rerunnable CANCELLED central runs (gh run rerun returns workflow 404). Closing and reopening to emit fresh required-workflow events; no source change is intended.

@seonghobae seonghobae closed this Jul 9, 2026
auto-merge was automatically disabled July 9, 2026 16:24

Pull request was closed

@seonghobae seonghobae reopened this Jul 9, 2026
@seonghobae
seonghobae enabled auto-merge July 9, 2026 16:24
@seonghobae

Copy link
Copy Markdown
Contributor Author

Second required-workflow refresh completed.

Current blocker was not source code: PR head 7cf8a6b is approved, mergeable, review threads are empty, and PR-scoped code scanning alerts are empty. The blocking checks were non-rerunnable cancelled central required workflow runs; direct gh run rerun --failed returns workflow 404 for those run ids, so I used the event path available from the PR itself.

Actions taken:

  • closed and reopened the PR to emit fresh required-workflow events;
  • re-applied policy-compliant auto-merge with gh pr merge 47 --merge --auto --delete-branch.

No source change was made.

@opencode-agent
opencode-agent Bot disabled auto-merge July 9, 2026 18:22

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

  • Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

  • Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

  • Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

  • Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

  • Result: REQUEST_CHANGES

  • Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head 7cf8a6bcd192281caf75b59570d9e2ce54244338.

  • Head SHA: 7cf8a6bcd192281caf75b59570d9e2ce54244338

  • Workflow run: 29033297875

  • Workflow attempt: 1

Coverage evidence

Coverage Evidence

  • Head SHA: 7cf8a6bcd192281caf75b59570d9e2ce54244338
  • Required test evidence: supported repository test suites must pass.
  • Required docstring evidence: repository-owned docstring gates must pass when configured; otherwise docstring coverage is advisory.

Python project dependencies (.)

Using CPython 3.12.3 interpreter at: /usr/bin/python3
Creating virtual environment at: .venv
Resolved 13 packages in 246ms
   Building fast-mlsirm @ file:///home/runner/work/fast-mlsirm/fast-mlsirm/pr-head
Downloading pygments (1.2MiB)
Downloading numpy (15.9MiB)
 Downloaded pygments
 Downloaded numpy
      Built fast-mlsirm @ file:///home/runner/work/fast-mlsirm/fast-mlsirm/pr-head
Prepared 7 packages in 923ms
Installed 7 packages in 18ms
 + fast-mlsirm==0.1.0 (from file:///home/runner/work/fast-mlsirm/fast-mlsirm/pr-head)
 + iniconfig==2.3.0
 + numpy==2.5.1
 + packaging==26.2
 + pluggy==1.6.0
 + pygments==2.20.0
 + pytest==9.1.1
  • Result: PASS

Python coverage with missing-line report (.)

Installed 6 packages in 9ms
============================= test session starts ==============================
platform linux -- Python 3.12.3, pytest-9.1.1, pluggy-1.6.0
rootdir: /home/runner/work/fast-mlsirm/fast-mlsirm/pr-head
configfile: pyproject.toml
collected 75 items

tests/test_cli.py ...............                                        [ 20%]
tests/test_config.py ..................                                  [ 44%]
tests/test_diagnostics.py .............                                  [ 61%]
tests/test_fit_pipeline.py ..                                            [ 64%]
tests/test_io.py ..                                                      [ 66%]
tests/test_math.py .......                                               [ 76%]
tests/test_objective.py ......                                           [ 84%]
tests/test_report.py ..........                                          [ 97%]
tests/test_simulation.py ..                                              [100%]

============================== 75 passed in 1.17s ==============================
Installed 1 package in 3ms
Name                                Stmts   Miss  Cover   Missing
-----------------------------------------------------------------
python/fast_mlsirm/__init__.py          7      0   100%
python/fast_mlsirm/cli.py             227     47    79%   57, 59, 224-232, 260-268, 306-314, 344-345, 349-351, 378-386, 408-410, 454
python/fast_mlsirm/config.py           78      0   100%
python/fast_mlsirm/diagnostics.py     320     19    94%   44, 185, 313, 403, 624, 626, 632, 638, 652, 669, 671, 676, 678, 689, 694, 697, 701, 704, 708
python/fast_mlsirm/fit.py             176      0   100%
python/fast_mlsirm/io.py               50      0   100%
python/fast_mlsirm/math.py             32      0   100%
python/fast_mlsirm/objective.py       109      0   100%
python/fast_mlsirm/report.py          188     14    93%   21, 87, 135, 137, 245, 247, 278, 291, 327, 350, 356, 363, 372, 377
python/fast_mlsirm/simulation.py       29      0   100%
python/fast_mlsirm/types.py            57      0   100%
tests/test_cli.py                     148      0   100%
tests/test_config.py                   57      0   100%
tests/test_diagnostics.py              86      0   100%
tests/test_fit_pipeline.py             16      0   100%
tests/test_io.py                       16      0   100%
tests/test_math.py                     63      0   100%
tests/test_objective.py                66      0   100%
tests/test_report.py                  112      0   100%
tests/test_simulation.py               18      0   100%
-----------------------------------------------------------------
TOTAL                                1855     80    96%
  • Result: PASS

Python docstring coverage advisory

RESULT: FAILED (minimum: 80.0%, actual: 1.4%)
  • Result: PASS

Rust coverage tooling (cargo-llvm-cov)

    Updating crates.io index
 Downloading crates ...
  Downloaded cargo-llvm-cov v0.8.7
  Installing cargo-llvm-cov v0.8.7
    Updating crates.io index
    Updating crates.io index
 Downloading crates ...
  Downloaded autocfg v1.5.0
  Downloaded anyhow v1.0.102
  Downloaded bitflags v2.11.1
  Downloaded shared_child v1.1.1
  Downloaded xattr v1.6.1
  Downloaded cfg-if v1.0.4
  Downloaded shared_thread v0.2.0
  Downloaded shell-escape v0.1.5
  Downloaded serde_spanned v1.1.1
  Downloaded same-file v1.0.6
  Downloaded os_pipe v1.2.3
  Downloaded opener v0.8.4
  Downloaded termcolor v1.4.1
  Downloaded zmij v1.0.21
  Downloaded lcov2cobertura v1.0.9
  Downloaded glob v0.3.3
  Downloaded errno v0.3.14
  Downloaded itoa v1.0.18
  Downloaded fs-err v3.3.0
  Downloaded toml_parser v1.1.2+spec-1.1.0
  Downloaded rustc-demangle v0.1.27
  Downloaded lexopt v0.3.2
  Downloaded walkdir v2.5.0
  Downloaded toml v1.1.2+spec-1.1.0
  Downloaded unicode-ident v1.0.24
  Downloaded tar v0.4.45
  Downloaded memchr v2.8.0
  Downloaded serde v1.0.228
  Downloaded ruzstd v0.8.3
  Downloaded serde_json v1.0.149
  Downloaded regex v1.12.3
  Downloaded winnow v1.0.2
  Downloaded cargo-config2 v0.1.44
  Downloaded quick-xml v0.39.4
  Downloaded aho-corasick v1.1.4
  Downloaded serde_core v1.0.228
  Downloaded quote v1.0.45
  Downloaded duct v1.1.1
  Downloaded syn v2.0.117
  Downloaded bstr v1.12.1
  Downloaded camino v1.2.2
  Downloaded serde_derive v1.0.228
  Downloaded regex-syntax v0.8.10
  Downloaded rustix v1.1.4
  Downloaded proc-macro2 v1.0.106
  Downloaded toml_datetime v1.1.1+spec-1.1.0
  Downloaded filetime v0.2.29
  Downloaded regex-automata v0.4.14
  Downloaded libc v0.2.186
  Downloaded linux-raw-sys v0.12.1
   Compiling serde_core v1.0.228
   Compiling memchr v2.8.0
   Compiling libc v0.2.186
   Compiling proc-macro2 v1.0.106
   Compiling aho-corasick v1.1.4
   Compiling unicode-ident v1.0.24
   Compiling regex-syntax v0.8.10
   Compiling quote v1.0.45
   Compiling rustix v1.1.4
   Compiling winnow v1.0.2
   Compiling serde v1.0.228
   Compiling zmij v1.0.21
   Compiling anyhow v1.0.102
   Compiling autocfg v1.5.0
   Compiling regex-automata v0.4.14
   Compiling linux-raw-sys v0.12.1
   Compiling bitflags v2.11.1
   Compiling fs-err v3.3.0
   Compiling serde_spanned v1.1.1
   Compiling toml_datetime v1.1.1+spec-1.1.0
   Compiling toml_parser v1.1.2+spec-1.1.0
   Compiling syn v2.0.117
   Compiling cfg-if v1.0.4
   Compiling camino v1.2.2
   Compiling serde_json v1.0.149
   Compiling filetime v0.2.29
   Compiling xattr v1.6.1
   Compiling regex v1.12.3
   Compiling bstr v1.12.1
   Compiling toml v1.1.2+spec-1.1.0
   Compiling serde_derive v1.0.228
   Compiling shared_child v1.1.1
   Compiling os_pipe v1.2.3
   Compiling quick-xml v0.39.4
   Compiling itoa v1.0.18
   Compiling shared_thread v0.2.0
   Compiling same-file v1.0.6
   Compiling rustc-demangle v0.1.27
   Compiling lcov2cobertura v1.0.9
   Compiling walkdir v2.5.0
   Compiling cargo-config2 v0.1.44
   Compiling duct v1.1.1
   Compiling opener v0.8.4
   Compiling tar v0.4.45
   Compiling termcolor v1.4.1
   Compiling shell-escape v0.1.5
   Compiling ruzstd v0.8.3
   Compiling lexopt v0.3.2
   Compiling glob v0.3.3
   Compiling cargo-llvm-cov v0.8.7
    Finished `release` profile [optimized] target(s) in 1m 03s
  Installing /home/runner/.cargo/bin/cargo-llvm-cov
   Installed package `cargo-llvm-cov v0.8.7` (executable `cargo-llvm-cov`)
  • Result: PASS

Rust coverage with missing-line report

info: cargo-llvm-cov currently setting cfg(coverage); you can opt-out it by passing --no-cfg-coverage
info: running `rustup component add llvm-tools-preview --toolchain stable-x86_64-unknown-linux-gnu` to install the `llvm-tools-preview` component for the selected toolchain
info: downloading component llvm-tools
   Compiling mlsirm-core v0.1.0 (/home/runner/work/fast-mlsirm/fast-mlsirm/pr-head/crates/mlsirm-core)
    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.99s
     Running unittests src/lib.rs (target/llvm-cov-target/debug/deps/mlsirm_core-dad37cea16f0abb2)

running 2 tests
test tests::gradient_matches_finite_difference_for_tau ... ok
test tests::single_item_matches_manual_nll ... ok

test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

Filename                                                                            Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/runner/work/fast-mlsirm/fast-mlsirm/pr-head/crates/mlsirm-core/src/lib.rs         267                15    94.38%          11                 1    90.91%         184                 5    97.28%           0                 0         -
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                   267                15    94.38%          11                 1    90.91%         184                 5    97.28%           0                 0         -
Uncovered Lines:
/home/runner/work/fast-mlsirm/fast-mlsirm/pr-head/crates/mlsirm-core/src/lib.rs: 78, 99, 129, 160
  • Result: FAIL (exit 1)

Coverage Decision

  • Result: FAIL
  • Test evidence: not proven passing
  • Docstring evidence: not proven passing when configured
  • Failure count: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file: report.py"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file: report.py"]
  R1 --> V1["required checks"]
  Evidence --> S2["Test: test_report.py"]
  S2 --> I2["regression suite"]
  I2 --> R2["Review risk: Test: test_report.py"]
  R2 --> V2["targeted test run"]
Loading

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

  • Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

  • Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

  • Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

  • Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

  • Result: REQUEST_CHANGES

  • Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head aac355f0f9eb29633a492ed1dbb57f9bf0bdaa7c.

  • Head SHA: aac355f0f9eb29633a492ed1dbb57f9bf0bdaa7c

  • Workflow run: 29074434518

  • Workflow attempt: 1

Coverage evidence

Coverage evidence job did not run or did not publish coverage evidence.

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (10 files)"]
  S1 --> I1["repository behavior"]
  I1 --> Conflict["Merge conflict blocks this path"]
  Conflict --> V1["required checks"]
  Evidence --> S2["Workflow (3 files)"]
  S2 --> I2["GitHub Actions review job"]
  I2 --> Conflict["Merge conflict blocks this path"]
  Conflict --> V2["actionlint plus required checks"]
  Evidence --> S3["Test: test_report.py"]
  S3 --> I3["regression suite"]
  I3 --> Conflict["Merge conflict blocks this path"]
  Conflict --> V3["targeted test run"]
Loading

# Conflicts:
#	.github/dependabot.yml
#	.github/workflows/ci.yml
#	.github/workflows/codeql.yml
#	SECURITY.md
#	crates/mlsirm-core/src/lib.rs
Comment thread .clusterfuzzlite/Dockerfile Fixed

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode reviewed the current-head bounded evidence and found no blocking issues.

Findings

No blocking findings.

Summary

Approval sufficiency: bounded evidence supplied affirmative approval evidence for changed files, coverage/docstring posture, risk surfaces, and current-head verification; approval is not based merely on the absence of known blockers.
Verification posture: CodeGraph evidence was initialized and bounded current-head evidence reviewed for changed-file evidence including .clusterfuzzlite/Dockerfile, .clusterfuzzlite/build.sh, .clusterfuzzlite/project.yaml, .github/dependabot.yml, .github/workflows/cflite_pr.yml, and 6 more.
Linter/static: workflow/static review evidence is bounded by the current-head GitHub Checks gate and changed-file evidence.
TDD/regression: coverage execution evidence and focused changed hunks were reviewed from bounded-review-evidence.md.
Coverage: coverage execution evidence reports supported repository test suites passed.
Docstring coverage: coverage execution evidence reports configured repository docstring gates passed or docstring coverage was advisory.
DAG: CodeGraph/source-backed behavior map connects .clusterfuzzlite/Dockerfile to the affected review, runtime, or workflow path and required checks.
PoC/execution: coverage-evidence job executed on the current head and reported PASS.
DDD/domain: workflow and repository-governance invariants were reviewed against changed files in bounded evidence.
CDD/context: CodeGraph evidence, changed-file history, and focused hunks were reviewed from bounded-review-evidence.md.
Similar issues: changed-file history evidence was reviewed for comparable local precedents.
Claim/concept check: bounded evidence, repository source, current-head workflow evidence, and, where numeric, scientific, statistical, or literature-backed claims are affected, original-paper/formula evidence and parameter-recovery expectations were used for claims.
Standards search: standards and external-source checks are delegated to configured OpenCode web_search/Context7/DeepWiki sources when applicable; no evidence-backed standards blocker is present in bounded evidence.
Compatibility/convention: changed workflow/script conventions, object naming, and reserved-word safety for schema/API/config/code surfaces were checked in bounded evidence.
Breaking-change/backcompat: deployment evidence and changed-file history were checked for backward-compatibility risk.
Performance: changed surfaces were checked for performance risk in bounded evidence.
Developer experience: changed automation, review, test, setup, and maintenance surfaces were checked for helpful or obstructive DX impact in bounded evidence.
User experience: connected user, operator, API, CLI, documentation, review-comment, status-check, rendering, and workflow-reader behavior was checked for contradictions against code, docs, and tests in bounded evidence.
Visual/DOM: Playwright visual, DOM locator, ARIA snapshot, console, and responsive evidence were checked when a web UI surface was present; for non-web surfaces, API/CLI/log/docs/workflow interaction evidence was reviewed instead.
Accessibility/i18n: accessibility, localization, and human-readable text surfaces were checked where UI, CLI, API message, docs, logs, or review text changed.
Supply-chain/license: dependency, package, model, container, and external-tool changes were checked in bounded evidence.
Packaging: package, build, test, lint, and security contracts were checked in bounded evidence.
Security/privacy: workflow-token, review-gate, and repository-automation security/privacy boundaries were checked in bounded evidence.

  • Result: APPROVE
  • Reason: All tests pass, no blocking issues, and changes improve report functionality.
  • Head SHA: e31f5101e0b0d5c882744868e9809667486a8d81
  • Workflow run: 29076448669
  • Workflow attempt: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (9 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (9 files)"]
  R1 --> V1["required checks"]
  Evidence --> S2["Workflow: cflite_pr.yml"]
  S2 --> I2["GitHub Actions review job"]
  I2 --> R2["Review risk: Workflow: cflite_pr.yml"]
  R2 --> V2["actionlint plus required checks"]
  Evidence --> S3["Test: test_report.py"]
  S3 --> I3["regression suite"]
  I3 --> R3["Review risk: Test: test_report.py"]
  R3 --> V3["targeted test run"]
Loading

@seonghobae
seonghobae dismissed stale reviews from github-actions[bot] and github-actions[bot] July 10, 2026 07:43

Dismissed stale coverage-evidence request on old head; current head e31f510 has passing checks, resolved threads, no open code-scanning alerts, and current-head OpenCode approval.

@seonghobae
seonghobae merged commit 28dd140 into main Jul 10, 2026
26 checks passed
@seonghobae
seonghobae deleted the codex/report-chart-later-values branch July 10, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants