Skip to content

Commit c299092

Browse files
committed
Say plainly that a person's Bots share their computer, and fix the rest of the review
A person's computer follows the industry standard for an always-on agent's computer: every Bot the person uses runs on it, a public Bot somebody else made included, and a command any of them runs can reach anything there. The admin Computers screen and the provider's description now say so, and an isolated Bot's Setup says before it is made public, and while it is, that everybody who uses it shares its computer and what is signed in to there. Also from the review: - Ticking Isolated asks the Bot owner's switch, the one runs are decided by, not the editor's, so an administrator can no longer save a tick the Bot never runs with. - A Sandbox is cut by computer key: an isolated Bot keeps its files at the root of the volume it had, instead of having them hidden by a new workspace root. - With the supervisor, a private Bot's old files come to its folder on its owner's computer, once, the same way its old profile does. - A reset also forgets snapshots and page pictures filed under the Bot alone from before computers were per person. - Helm's computer requests 2Gi with an 8Gi limit, sized for a person's browsers, with sizing guidance in values.yaml. - An unreadable Isolated switch is logged, not silently read as off.
1 parent 336358a commit c299092

261 files changed

Lines changed: 906 additions & 602 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎CHANGELOG.md‎

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,10 @@ Newest first. `Unreleased` is what is on `main` and not yet tagged.
1616
when it starts, keeping their volumes. A private Bot's logins are copied into its owner's computer
1717
once; public Bots, the built-in ones included, sign in again once, because their old logins were
1818
shared by everyone who used them. Helm `shared` moves private Bots' profiles the same way. On Helm
19-
`sandbox` nothing is copied, so private Bots sign in again once there too. Old per-Bot volumes are
20-
left in place; remove them when you are satisfied.
19+
`sandbox` nothing is copied, so private Bots sign in again once there too. With the supervisor, a
20+
private Bot's files come along the same way, into its folder on its owner's computer; a public
21+
Bot's old files stay in its old volume. Old per-Bot volumes are left in place; remove them when you
22+
are satisfied. Helm's computer memory defaults rise to a 2Gi request and an 8Gi limit.
2123
- A hosted computer's browser is now headed by default. It uses a little more memory than headless
2224
did; set `COMPUTER_BROWSER_MODE=headless` (Helm: `computers.browserMode: headless`) to keep the old
2325
behaviour.
@@ -113,6 +115,22 @@ groups. When it is turned off for somebody, their isolated Bots run on their own
113115
next run, and the Bot's Setup says why. A deployment with one shared computer (Helm `shared`, or no
114116
supervisor) cannot give a Bot its own, and the checkbox says so.
115117

118+
As is the industry standard for an always-on agent's computer, the Bots on a person's computer are
119+
not kept from each other: a command any of them runs, a public Bot somebody else made included, can
120+
reach anything on that computer. Each Bot still keeps its own browser profile there, which is
121+
stricter than the standard, where a person's Bots share their sign-ins too. The admin Computers
122+
screen says this, and a Bot that must be kept apart is made Isolated.
123+
124+
An isolated Bot's one computer is shared by everybody who uses it, so its Setup says, before it is
125+
made public and while it is, that anything signed in to there is theirs too. Only the Bot's owner's
126+
switch decides whether it may be isolated: an administrator ticking Isolated on somebody else's Bot
127+
is refused when that owner lacks the switch, rather than saving a tick the Bot never ran with.
128+
129+
A person's computer runs a browser for each of their Bots in use, so Helm's computer now requests
130+
2Gi of memory with an 8Gi limit (was 1Gi and 4Gi); `computers.resources` in values.yaml says how to
131+
size it. Removing a person or deleting an isolated Bot leaves its computer until an administrator
132+
resets it from Admin → Computers, which signs every Bot on it out of everything.
133+
116134
### The audit log reads like a log
117135

118136
Admin → Audit fills the window and runs the table across the whole pane, with the title, the views

‎agent-computer/src/browser-runtime.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { browserModeFromEnv, type BrowserMode } from "./browser-mode";
1+
import { type BrowserMode, browserModeFromEnv } from "./browser-mode";
22

33
export type BrowserRuntime = {
44
backend: "managed" | "local-chrome";

‎agent-computer/src/challenge.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import type { Page } from "playwright";
22
import type { BrowserChallenge } from "../../shared/computer-control";
33
import type { Control } from "./control";
4+
45
type Signal = {
56
cfMitigated?: string | null;
67
text: string;

‎agent-computer/tests/follows-popup.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1+
import { afterAll, describe, expect, test } from "bun:test";
12
import { mkdtemp, rm } from "node:fs/promises";
23
import { tmpdir } from "node:os";
34
import { join } from "node:path";
4-
import { afterAll, describe, expect, test } from "bun:test";
55

66
/**
77
* Asked for by name, like the deployment journey at the repository root: it launches a real Chromium,

‎agent-computer/tests/local-chrome-startup.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { describe, expect, test } from "bun:test";
2-
import { join } from "node:path";
32
import { createServer } from "node:net";
3+
import { join } from "node:path";
44
import {
55
localChromeConfiguration,
66
requireAvailablePort,

‎agent-computer/tests/person-browser-rules.test.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,21 +14,23 @@ import {
1414
RECORDER_EXTENSION_ID,
1515
RECORDER_NATIVE_HOST,
1616
} from "../../shared/recorder-extension";
17+
import { navigationFailure } from "../src/navigation";
1718
import {
1819
computerOwner,
1920
NOT_ITS_OWN_COMPUTER,
2021
ONLY_THE_PERSONS,
2122
personMayUse,
2223
refusedHere,
2324
} from "../src/person-access";
25+
import { isBrowserNotInstalled, PersonOpenError } from "../src/person-browser";
2426
import {
27+
browserExecutableCandidates,
2528
copyNativeMessagingHosts,
2629
defaultNativeMessagingHosts,
2730
forgetRecorderPins,
2831
PLAYWRIGHT_DEFAULTS_A_PERSON_DOES_NOT_GET,
2932
personBrowserEnv,
3033
personLaunchOptions,
31-
browserExecutableCandidates,
3234
personNativeLaunch,
3335
runnable,
3436
} from "../src/person-launch";
@@ -37,8 +39,6 @@ import {
3739
findRecorder,
3840
isRecorderSetupPage,
3941
} from "../src/recorder";
40-
import { navigationFailure } from "../src/navigation";
41-
import { isBrowserNotInstalled, PersonOpenError } from "../src/person-browser";
4242
import { addressFrom } from "../src/request-validation";
4343

4444
/**

‎agent-computer/tests/profile-launch-options.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import { afterEach, describe, expect, spyOn, test } from "bun:test";
22
import { existsSync } from "node:fs";
33
import { mkdtemp, rm } from "node:fs/promises";
4-
import { join } from "node:path";
54
import { tmpdir } from "node:os";
5+
import { join } from "node:path";
66
import { PLAYWRIGHT_DISABLED_FEATURES } from "../src/person-launch";
77

88
const original = { ...process.env };

‎agent-computer/tests/session-cookies.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1+
import { afterAll, describe, expect, test } from "bun:test";
12
import { mkdtemp, readFile, rm, stat } from "node:fs/promises";
23
import { tmpdir } from "node:os";
34
import { join } from "node:path";
4-
import { afterAll, describe, expect, test } from "bun:test";
55
import type { Cookie } from "playwright";
66
import {
77
cookiesToRestore,

‎agent-computer/tests/virtual-display.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import { describe, expect, test } from "bun:test";
22
import {
3-
startVirtualDisplay,
43
type DisplayProcess,
54
type DisplayRuntime,
5+
startVirtualDisplay,
66
} from "../src/virtual-display";
77

88
function deferred<T>() {

‎app/scripts/serve-or-build.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import { dirname, join, resolve } from "node:path";
22
import { fileURLToPath } from "node:url";
33
import {
4+
type BuildCachePaths,
45
isReusableBuild,
56
writeBuildCacheManifest,
6-
type BuildCachePaths,
77
} from "./build-cache";
88

99
type RunCommand = (command: string[], cwd: string) => Promise<void>;

0 commit comments

Comments
 (0)