Skip to content

Commit eac7920

Browse files
committed
Say that a remote Bot hands work on, and drop the extraEnv note the chart replaced
architecture doc no longer describes every such hop as refused. #717 gives the delivery, SCIM, inbound email and OTel settings their own chart values, which supersedes the extraEnv guidance.
1 parent 6ab3b3f commit eac7920

2 files changed

Lines changed: 4 additions & 13 deletions

File tree

‎charts/openbot/README.md‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -344,16 +344,6 @@ delivers anything. `config.learning.containerId` sets the initial default contai
344344
Automatic Learning take precedence, including switching it off. See
345345
[docs/automatic-learning.md](../../docs/automatic-learning.md).
346346

347-
## Settings with no value of their own
348-
349-
Several server settings have no dedicated chart value and are passed through `config.extraEnv` or
350-
`config.extraEnvFrom`: OpenTag delivery to Slack and Teams (`OPENTAG_URL`, `OPENTAG_SHARED_SECRET`),
351-
text messages (`TWILIO_*`), mobile push (`EXPO_ACCESS_TOKEN`, `EXPO_PROJECT_ID`), inbound email for
352-
Responsibilities (`OPENBOT_INBOUND_EMAIL_DOMAIN`, `OPENBOT_INBOUND_EMAIL_SNS_TOPIC_ARNS`), SCIM
353-
(`SCIM_*`), OpenTelemetry export (`OPENBOT_OTEL_EXPORT`, `OTEL_*`) and `DELIVERY_PUBLIC_URL`.
354-
`.env.example` describes each. Put the secret ones in a Secret and name it in `config.extraEnvFrom`
355-
rather than writing them into a values file.
356-
357347
## Slack, Teams, text messages, push, SCIM, inbound email and OpenTelemetry
358348

359349
Each is off until its values are set, and each is the same setting [docs/configuration.md](../../docs/configuration.md)

‎docs/architecture.md‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -271,9 +271,10 @@ through the signed callback route is dispatched the same way as one from a Bot r
271271
handed work is not the same as being able to hand it on, so the target of a grant may live at
272272
its own endpoint.
273273

274-
One limit remains on the asking side. The grant check a hop goes through (`botsReachableFrom`) counts
275-
only grants held by built-in Bots, so a Bot at its own endpoint can be granted another Bot and can ask
276-
its person, but every hop it attempts is refused as not granted.
274+
The asking side works the same way. The grant check a hop goes through (`botsReachableFrom`) counts a
275+
grant whatever the asking Bot's type, so a Bot at its own endpoint hands work on through the signed
276+
callback, the same grant check, caps and audit rows as a built-in one, to a built-in Bot or to another
277+
Bot at its own endpoint.
277278

278279
A coworker created through the UI with an endpoint is a remote one. Created without one, it runs at
279280
the managed Bot's endpoint when the deployment has one, and otherwise runs here as a built-in Bot on

0 commit comments

Comments
 (0)