[#198]: add CLI tests and update test file names for clarity

Author: siddh34

.github/workflows/core-build-checks.yml

@@ -51,6 +51,18 @@ jobs:
       working-directory: core
       run: cargo test --locked -p cortexbrain-common --test public_contracts --no-default-features --features network-structs,monitoring-structs
 
+  test-cli:
+    name: Test CLI
+    runs-on: ubuntu-latest
+
+    steps:
+    - name: Checkout code
+      uses: actions/checkout@v4
+
+    - name: Test CLI
+      working-directory: cli
+      run: cargo test --locked
+
   build-core-components:
     runs-on: ubuntu-latest
 

cli/src/install.rs

@@ -526,7 +526,7 @@ mod tests {
 
     #[test]
     fn test_rm_file() {
-        let file_name = "test_file.txt";
+        let file_name = "test_rm_file.txt";
         std::fs::write(file_name, "test content").unwrap();
         assert!(rm_file(file_name).is_ok());
         assert!(!std::path::Path::new(file_name).exists());
@@ -558,30 +558,30 @@ mod tests {
 
     #[test]
     fn test_rm_file_cleanup_only() {
-        let file_name = "test_file.txt";
+        let file_name = "test_rm_file_cleanup_only.txt";
         std::fs::write(file_name, "test content").unwrap();
         // Clean up without removing
         rm_file(file_name).unwrap();
     }
 
     #[test]
     fn test_rm_file_failure_cleanup() {
-        let file_name = "non_existent_file.txt";
+        let file_name = "test_rm_file_failure_cleanup.txt";
         // Attempt to clean up a non-existent file
         assert!(rm_file(file_name).is_err());
     }
 
     #[test]
     fn test_rm_file_success_cleanup() {
-        let file_name = "test_file.txt";
+        let file_name = "test_rm_file_success_cleanup.txt";
         std::fs::write(file_name, "test content").unwrap();
         // Clean up a file that exists
         assert!(rm_file(file_name).is_ok());
     }
 
     #[test]
     fn test_rm_file_success_cleanup_only() {
-        let file_name = "test_file.txt";
+        let file_name = "test_rm_file_success_cleanup_only.txt";
         std::fs::write(file_name, "test content").unwrap();
         // Clean up a file that exists
         assert!(rm_file(file_name).is_ok());

cli/src/logs.rs

@@ -4,7 +4,7 @@ use crate::essential::{BASE_COMMAND, connect_to_client};
 use clap::Args;
 use colored::Colorize;
 use kube::{Error, core::ErrorResponse};
-use std::{result::Result::Ok, str};
+use std::{process::Command, result::Result::Ok, str};
 
 fn parse_lines(stdout: &[u8]) -> Vec<String> {
     str::from_utf8(stdout)

cli/src/policies.rs

@@ -146,7 +146,7 @@ mod tests {
 
     #[test]
     fn test_parse_create_blocklist_with_ip() {
-        let cli = TestCli::try_parse_from(["cfcli", "create-blocklist", "--flags", "1.2.3.4"])
+        let cli = TestCli::try_parse_from(["cfcli", "--flags", "1.2.3.4", "create-blocklist"])
             .unwrap();
         assert!(matches!(
             cli.args.policy_cmd,
@@ -168,7 +168,7 @@ mod tests {
     #[test]
     fn test_parse_remove_ip() {
         let cli =
-            TestCli::try_parse_from(["cfcli", "remove-ip", "--flags", "5.6.7.8"]).unwrap();
+            TestCli::try_parse_from(["cfcli", "--flags", "5.6.7.8", "remove-ip"]).unwrap();
         assert!(matches!(
             cli.args.policy_cmd,
             PoliciesCommands::RemoveIpFromBlocklist