Skip to content

Commit 3213cc5

Browse files
committed
Fix global log_std implementation
1 parent f82bc49 commit 3213cc5

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/engine/server/NN/ModelManager.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ int64_t h_start = 1024; // 1024 256
2626
double std_dev = 0.37; // log(0.37) ~ -1
2727
double learning_rate = 5e-5;
2828
double actor_learning_rate = 3e-4;
29-
//double log_std_learning_rate = 1e-4;
29+
double log_std_learning_rate = 1e-4;
3030
double critic_learning_rate = 1e-3;
3131
//double weight_decay = 0.0001;
3232

@@ -158,8 +158,8 @@ ModelManager::ModelManager(bool is_training, std::string train_folder, size_t ba
158158
std::make_unique<torch::optim::AdamOptions>(actor_learning_rate)));
159159
param_groups.push_back(torch::optim::OptimizerParamGroup({ac_update->critic_network->parameters()},
160160
std::make_unique<torch::optim::AdamOptions>(critic_learning_rate)));
161-
//param_groups.push_back(torch::optim::OptimizerParamGroup({ac_update->log_std_},
162-
//std::make_unique<torch::optim::AdamOptions>(log_std_learning_rate)));
161+
param_groups.push_back(torch::optim::OptimizerParamGroup({ac_update->log_std_},
162+
std::make_unique<torch::optim::AdamOptions>(log_std_learning_rate)));
163163

164164
opt = std::make_shared<torch::optim::Adam>(param_groups);
165165

src/engine/server/NN/Models.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ struct ActorCriticImpl : public torch::nn::Module
234234
auto gaussian_entropy = 0.5 + 0.5 * log(2 * M_PI) + log_std_;
235235
//std::cout << gaussian_entropy.sizes() << std::endl;
236236
// Sum over the last dimension (angle components)
237-
return gaussian_entropy.sum(1); // Shape [...]
237+
return gaussian_entropy.sum(); // Shape [...]
238238
}
239239

240240
// Bernoulli entropy

0 commit comments

Comments
 (0)