Repository navigation
Commit cb9cfff
committed
Return false from AutoCommit once Close has started
AutoCommit takes c.mu, which Close holds while SQLite runs callbacks
such as the rollback hook. Since 0f12d4e moved the lock in Close in
front of sqlite3_close_v2 (v1.14.37), a callback that calls AutoCommit
waits for c.mu forever.
Check the closing flag before taking c.mu, as dbConnOpen does, and
report false, as AutoCommit does after Close.1 parent c1910db commit cb9cfff
2 files changed
Lines changed: 19 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1102 | 1102 | | |
1103 | 1103 | | |
1104 | 1104 | | |
1105 | | - | |
| 1105 | + | |
1106 | 1106 | | |
| 1107 | + | |
| 1108 | + | |
| 1109 | + | |
1107 | 1110 | | |
1108 | 1111 | | |
1109 | 1112 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3103 | 3103 | | |
3104 | 3104 | | |
3105 | 3105 | | |
3106 | | - | |
| 3106 | + | |
3107 | 3107 | | |
3108 | 3108 | | |
3109 | | - | |
3110 | | - | |
| 3109 | + | |
| 3110 | + | |
3111 | 3111 | | |
3112 | 3112 | | |
3113 | 3113 | | |
3114 | 3114 | | |
3115 | 3115 | | |
3116 | 3116 | | |
3117 | | - | |
| 3117 | + | |
| 3118 | + | |
| 3119 | + | |
| 3120 | + | |
| 3121 | + | |
3118 | 3122 | | |
3119 | 3123 | | |
3120 | | - | |
| 3124 | + | |
3121 | 3125 | | |
3122 | 3126 | | |
3123 | 3127 | | |
| |||
3135 | 3139 | | |
3136 | 3140 | | |
3137 | 3141 | | |
3138 | | - | |
3139 | | - | |
3140 | | - | |
| 3142 | + | |
| 3143 | + | |
| 3144 | + | |
| 3145 | + | |
| 3146 | + | |
| 3147 | + | |
3141 | 3148 | | |
3142 | 3149 | | |
3143 | 3150 | | |
| |||
0 commit comments