Repository navigation
Run the tests with go test instead of go-acc, and test Go 1.26 and 1.27 - #10
Merged
Merged
Conversation
ory/go-acc is archived, and every run installed its latest version with its own dependencies. For a single package it only runs go test with a coverage profile, which go test writes itself; with -race the cover mode is atomic, as go-acc set it.
CovenantSQL builds with Go 1.27, which CI did not test. Go supports the two latest releases, 1.26 and 1.27, so 1.24 and 1.25 are dropped. go.mod still requires Go 1.21.
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test job installs
github.com/ory/go-acc@lateston every run, with its own dependencies (Cobra, Viper and others), to collect coverage. go-acc is archived. With a single package it only runsgo testwith a coverage profile of that package, whichgo testwrites by itself, and with-racethe cover mode is atomic, as go-acc set it. The first commit runsgo test -race -v -coverprofile=coverage.txt -tags "…"in each step instead and drops the install andPATHsteps.The matrix tested Go 1.24, 1.25 and 1.26, but CovenantSQL builds this package with Go 1.27 (its
ci.ymland builder image). The second commit tests Go 1.26 and 1.27, the two releases Go supports.go.modstays atgo 1.21: nothing here needs a newer language version.CI only; the package does not change.
Left out:
developtoo, withToken required because branch is protected(fail_ci_if_erroris false, so the job still passes), so the coverage reaches nobody. Adding aCODECOV_TOKENsecret, or dropping the upload and-coverprofile, is a separate decision. The step'sfileinput, which codecov-action v5 reports as unexpected, is also left as it is.coverage.txt, as with go-acc, so only the last tag set would be uploaded.go build), and a job for Go 1.21.Testing
cql-ci:go1.27pluslibsqlite3-dev, andgolang:1.26pluslibicu-devandlibsqlite3-dev), with Go 1.27.3 and Go 1.26.10,--cpus 4: the fourgo testcommands, taken from the workflow file as written, pass, and each writes acoverage.txtthat starts withmode: atomic. Coverage is 65.1%, 64.5%, 65.1% and 65.1% of statements for the default,libsqlite3, full andsqlite_vacuum_fullsteps, the figures go-acc reported for Go 1.26 in the lastdeveloprun.