Warn on Any return

Author: CraftSpider

discord/ext/test/backend.py

@@ -21,7 +21,7 @@
 
 from discord.types import member
 from requests import Response
-from typing import NamedTuple, Any, ClassVar, NoReturn, Literal, Pattern, overload, Sequence, Iterable
+from typing import NamedTuple, Any, ClassVar, NoReturn, Literal, Pattern, overload, Sequence, Iterable, reveal_type
 
 from . import factories as facts, state as dstate, callbacks, websocket, _types
 from ._types import Undef, undefined
@@ -391,16 +391,18 @@ async def get_members(
     async def get_member(self, guild_id: Snowflake,
                          member_id: Snowflake) -> _types.member.MemberWithUser:
         locs = _get_higher_locs(1)
-        guild = locs["self"]
+        guild: discord.Guild = locs["self"]
         member = discord.utils.get(guild.members, id=member_id)
+        if member is None:
+            raise ValueError(f"No member {member_id} in guild {guild_id}")
 
         return facts.dict_from_object(member)
 
     async def edit_role(self, guild_id: Snowflake, role_id: Snowflake, *,
                         reason: str | None = None,
                         **fields: Any) -> _types.role.Role:
         locs = _get_higher_locs(1)
-        role = locs["self"]
+        role: discord.Role = locs["self"]
         guild = role.guild
 
         await callbacks.dispatch_event(CallbackEvent.edit_role, guild, role, fields, reason=reason)
@@ -538,9 +540,11 @@ async def get_from_cdn(self, url: str) -> bytes:
     async def get_user(self, user_id: Snowflake) -> _types.user.User:
         # return self.request(Route('GET', '/users/{user_id}', user_id=user_id))
         locs = _get_higher_locs(1)
-        client = locs["self"]
+        client: discord.Client = locs["self"]
         guild = client.guilds[0]
         member = discord.utils.get(guild.members, id=user_id)
+        if member is None:
+            raise ValueError(f"Failed to locate user {user_id} in test state")
         return facts.dict_from_object(member._user)
 
     async def pin_message(self, channel_id: Snowflake, message_id: Snowflake,

discord/ext/test/state.py

@@ -50,7 +50,7 @@ def __init__(self, client: discord.Client, http: dhttp.HTTPClient, user: discord
 
         real_disp = self.dispatch
 
-        def dispatch(*args: Any, **kwargs: Any) -> T | None:
+        def dispatch(*args: Any, **kwargs: Any) -> Any | None:
             if not self._do_dispatch:
                 return None
             return real_disp(*args, **kwargs)

discord/ext/test/utils.py

@@ -4,6 +4,7 @@
 """
 
 import asyncio
+import collections
 from typing import TypeVar
 
 import discord
@@ -80,10 +81,12 @@ class PeekableQueue(asyncio.Queue[T]):
         internal artifacts
     """
 
+    _queue: collections.deque[T]
+
     def peek(self) -> T:
         """
             Peek the current last value in the queue, or raise an exception if there are no values
 
         :return: Last value in the queue, assuming there are any
         """
-        return self._queue[-1]  # type: ignore[attr-defined]
+        return self._queue[-1]

mypy.ini

@@ -3,6 +3,7 @@ packages = discord.ext.test, tests
 
 warn_redundant_casts = True
 warn_unused_ignores = True
+warn_return_any = True
 
 strict_equality = True