Skip to content

Commit 314fb0f

Browse files
committed
fix(preview): name the control, not where it happens to sit
The panel has three layouts and the page moves between them: beside the export column at full width, beside the knobs at two, above both when the window is narrow. So "the page above" is wrong in two of the three, and "the page on the left" in two others. Neither says anything a reader could not get from the word "preview". Six strings said it: the coverage and fallback tips, the sizes tip pointing at "the size on the left", the second family tip, the hinting tip counting switches by where they sit, and the fetch remedy's "Press Fetch, above".
1 parent 406ce28 commit 314fb0f

2 files changed

Lines changed: 10 additions & 11 deletions

File tree

src/crossglyph/preview/static/index.html

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@
290290
FreeType fit the font whatever instructions it carries, and is worth
291291
trying on a face that looks muddy at small sizes.
292292
<br><br>
293-
This row also decides what two of the switches below it can do.
293+
This row also decides what two of the switches can do.
294294
<strong>grayscale hinting</strong> is a choice between two ways of
295295
running the font's own instructions, so it needs a mode where those
296296
run, which for almost every font means <strong>normal</strong>.
@@ -925,8 +925,8 @@ <h2>Export</h2>
925925
aria-describedby="sizes-tip">?</button>
926926
<span class="tip" id="sizes-tip" role="tooltip">
927927
The reader's Font Size setting lists every size the family carries,
928-
one entry each. Not the size on the left, which is only what you
929-
are tuning at. A box takes a fraction, in the quarter points that
928+
one entry each. Not the <strong>size</strong> knob, which is only
929+
what you are tuning at. A box takes a fraction, in the quarter points that
930930
knob steps in, and rounds anything between them.
931931
</span>
932932
</span></span>
@@ -988,7 +988,7 @@ <h2><button type="button" id="mod-toggle" data-fold="mod"
988988
aria-describedby="mod-tip">?</button>
989989
<span class="tip" id="mod-tip" role="tooltip">
990990
More sizes, built from the same faces. With the suffix empty they
991-
join the family above, and the reader lists them among its sizes:
991+
join this family, and the reader lists them among its sizes:
992992
nothing limits how many one family carries. Fill the suffix in and
993993
they build <strong id="mod-name">a second family</strong> instead,
994994
listed beside the first under that name, which is worth having when
@@ -1055,7 +1055,7 @@ <h2><button type="button" id="mod-toggle" data-fold="mod"
10551055
Extra Unicode ranges, for books that need them. More coverage means
10561056
a larger file and a longer build.
10571057
<br><br>
1058-
The page above draws what a build of these ticks would draw. Untick
1058+
The preview draws what a build of these ticks would draw. Untick
10591059
a range the text uses and it goes blank there, the way the built
10601060
font would, and the note under the text box says which tick would
10611061
carry it.
@@ -1090,8 +1090,8 @@ <h2><button type="button" id="mod-toggle" data-fold="mod"
10901090
a glyph the family already has. Some uncommon codepoints may still
10911091
be left out of the <code>.cpfont</code>.
10921092
<br><br>
1093-
None of this decides the page on the left: a preview is built from
1094-
the text in the box, whatever is ticked here.
1093+
None of this decides what the preview draws: it is built from the
1094+
text in the box, whatever is ticked here.
10951095
</span>
10961096
</span>
10971097
</span>
@@ -1139,7 +1139,7 @@ <h2><button type="button" id="mod-toggle" data-fold="mod"
11391139
on a wide coverage they are the difference between 300 glyphs and
11401140
3,300.
11411141
<br><br>
1142-
The page above shows them too, in the same order the build would:
1142+
The preview shows them too, in the same order the build would:
11431143
paste a character this family has not got and you see which face it
11441144
will actually come from. Nothing is opened while the family covers
11451145
the text.

src/crossglyph/preview/static/js/export.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -403,9 +403,8 @@ function coverageAdvice(remedy, bundled) {
403403
// a folder the build does not read, and the range comes out as empty as
404404
// it was.
405405
return bundled
406-
? "Press Fetch, above, then build again."
407-
: "Press Fetch, above, turn on bundled fallback faces, then build "
408-
+ "again.";
406+
? "Press Fetch, then build again."
407+
: "Press Fetch, turn on bundled fallback faces, then build again.";
409408
}
410409
// The faces are here and this build did not use them. Usually the box is
411410
// off and pressing it is the whole answer; with it on, the order in the

0 commit comments

Comments
 (0)