Skip to content

ci: accept cross-repo issue references in the PR body check #5

Closed

Description

@Bugs5382

What and why

The PR Body check in each repo's .github/workflows/job-pr-checks.yaml only matches a same-repo reference, (closes|fixes|resolves|refs) #[0-9]+. A PR whose work is tracked in another repo's issue fails it, even though GitHub links the reference. Two open PRs are blocked this way: CryptOS-PKI/api#108 (Refs CryptOS-PKI/cryptos#278) and CryptOS-PKI/docs#15 (Refs CryptOS-PKI/cryptos#166).

Scope

Change only the PR Body step, in every repo that has it: cryptos, api, manager, web, helm and docs (lab and .github have no workflows). The rest of each workflow file stays byte-identical.

The step accepts GitHub's closing keywords plus Refs, in any casing, with an optional colon, followed by a reference GitHub links: #12, GH-12, owner/repo#12 or https://github.com/owner/repo/issues/12. It keeps rejecting a body with no reference, repo#12 without an owner, a fragment on another site and a keyword glued to other text. This is the same step the shared governance template already ships (Bugs5382/project-template#124).

One PR per repo, each saying Refs CryptOS-PKI/.github#<this issue>.

Done when

  • The six PRs are merged.
  • PR Checks is re-run on api#108 and docs#15 and passes.

Activity

  1. added this to the v1.0.0 milestone on Sep 30, 2026
  2. self-assigned this
    on Sep 30, 2026
  3. added theissue type on Sep 30, 2026
  4. Bugs5382 commented on Sep 30, 2026

    @Bugs5382
    ContributorAuthor

    PRs, one per repo, each changing only the PR Body step:

    Any order works; they are independent.

    Found along the way: in docs, the PR Checks gitleaks step scans every fetched branch, not just the PR's own commits (fetch-depth: 0 plus gitleaks detect). Commit 073a3c8 on docs/20-reference-pages (docs#35) trips the generic-api-key rule on docs/reference/root-cert-profile.md line 21, so every docs PR's PR Checks fails right now, docs#36 included. PR Body itself passes there. That is outside this issue.

  5. Bugs5382 commented on Sep 30, 2026

    @Bugs5382
    ContributorAuthor

    Done: every PR under this issue is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

skip-changelogExcluded from release notes (chore/ci/test/style).

Type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions