Repository navigation
feat(release): build the manager image from the cryptos-web tag of the same name - #211
Merged
Merged
Conversation
…e same name Refs #210 Signed-off-by: Bugs5382 <12115015+Bugs5382@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Closes #210
cryptos-manager and cryptos-web are versioned in lockstep. The release image now takes the web console from cryptos-web's tag of the same name (
github.ref_name) instead of theWEB_RELEASE_REFrepository variable, which had to be set by hand and was unset for v0.1.0-rc.1.releases/tagsendpoint returns published releases only, so a draft fails too.refs/tags/<same tag>.ci-image.yaml: builds pull requests against webmain; the variable fallback is gone.versioninput. Each repo resolves its next version from its own labels, so the manager and web drafts can differ. The input sets one to match before either is published.Companion PRs: the same drafter input in CryptOS-PKI/cryptos-web, and the release order in CryptOS-PKI/cryptos-appliance
docs/release.md. Once this merges I remove theWEB_RELEASE_REFrepository variable.Verification
actionlintpasses.v0.1.0-rc.1passes (published), andv9.9.9is refused.How this was verified
Locally with actionlint and the API check above. The guard's real run is the next manager tag.