Repository navigation
ci: align workflows with hub fixes - #136
Merged
Merged
Conversation
Move Release Drafter to release-drafter/release-drafter@v7 and pass the App token through the action's token input instead of env GITHUB_TOKEN, matching the hub templates. Signed-off-by: Bugs5382 <12115015+Bugs5382@users.noreply.github.com>
Bugs5382
marked this pull request as ready for review
September 30, 2026 14:17
Contributor
Author
|
Closing summary: moves release-drafter from v6 to v7 with the token passed as the token input (the repo's GitHub App token, which pushes the changelog commit). The setup-task repo-token item was already on main. The skipped-job names are kept as expressions on purpose: these workflows re-run on PR edits, and a static name would let an edit-skipped run share the real check's name. Signed off. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Brings this repo's workflows in line with the hub fixes tracked in Bugs5382/project-template#73.
release-drafter/release-drafter@v7, token passed aswith: token:instead ofenv: GITHUB_TOKEN(Bugs5382/project-template#56, Bugs5382/project-template#59). The token stays the GitHub App token (steps.app-token.outputs.token) this workflow already uses, since the same run pushes the CHANGELOG commit; only the version and how the token is passed change. The v7 outputs used by the later steps (body,resolved_version) are unchanged.arduino/setup-taskauthenticated withrepo-token: ${{ secrets.GITHUB_TOKEN }}(Bugs5382/project-template#60). Already onmain:job-golic.yamlusesarduino/setup-task@v2withrepo-token, matching the current hub template. No change needed.Skipped-job display names are left as they are on purpose. A job skipped on a title or body edit shows the raw
${{ ... }}name expression, but this repo reruns PR workflows onedited(so a retargeted stacked PR starts CI). With a static name, the skipped edit run would share the real check's name and count as passing, which could hide a failed check. The hub templates use static names because they don't trigger onedited.No docs change: CI workflow only.
Closes #102
Verification
How this was verified
actionlint .github/workflows/release-drafter.yml: clean.task license(golic v1.2.0 dry run): 0/181 changed, exit 0.npm ci --ignore-scripts,npm run lint,npm run test(373 passed),npm run build: all pass, tree clean afterwards.mainand stays gated onvars.APP_CLIENT_ID, so this PR's checks don't exercise it.Before merging: add a closing comment summarizing what was actually done in this PR
(not just the checked boxes).