Repository navigation
test(console): cover the first-run wizard's CA reconfirm path - #195
Merged
Merged
Conversation
CaStep's already-registered branch (ca-step.tsx) had no test: the wizard's existing tests only exercise a fresh registration, so a regression here (accepting a mismatched fingerprint, or never letting the operator continue) would not have been caught. Covers, through the public component: the already-registered state shows the fingerprint and keeps Confirm disabled until a paste is entered; the right paste enables Confirm and reconfirms without a new registration; a mismatch keeps Confirm disabled and explains why; Register a different CA cancels the reconfirm without registering anything; and a refused reconfirm surfaces inline without advancing. Refs #193 Signed-off-by: Bugs5382 <12115015+Bugs5382@users.noreply.github.com>
Bugs5382
marked this pull request as ready for review
October 15, 2026 20:20
github-actions
Bot
added
the
skip-changelog
Bugs5382
enabled auto-merge (squash)
October 15, 2026 23:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
CaStep's already-registered branch (apps/console/src/components/first-run/ca-step.tsx) had no
test: the wizard's existing tests only exercise a fresh registration, so a regression in the
reconfirm path -- accepting a mismatched fingerprint, or never letting the operator continue --
would not be caught.
This adds a focused test file on the public component, covering:
paste is entered
registering nothing
I confirmed these tests actually catch a regression (temporarily loosening the Confirm button's
guard locally, watching two of them fail, then reverting) before finishing.
No production code changed.
Refs #193
Verification
How this was verified
npm run lint(eslint + prettier --check): clean.npm run testacross all workspaces: 790 console + 247 ui tests pass, including the new file'saxe check.
npm run buildacross all workspaces: tsc + vite build succeed for console, tsc succeeds for ui.node scripts/check-release-bundle.mjs apps/console/dist: release bundle clean.