Repository navigation
fix(ci): run release drafter with GITHUB_TOKEN - #10
Merged
Merged
Conversation
The workflow only ran when the org GitHub App was configured, which it isn't, so every run was skipped and no draft release existed. Use the same token-based workflow as the docs repo. Refs #9 Signed-off-by: Bugs5382 <12115015+Bugs5382@users.noreply.github.com>
Contributor
Author
|
Merged. The release drafter now runs on push to main with GITHUB_TOKEN, and the v0.1.0-rc.1 draft is there. I'm leaving it unpublished until I tag the site release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The release drafter only ran when the org GitHub App was set up. It isn't, so the run after #2 was skipped and there's no draft release. Publishing that draft is what tags a site release and starts the Cloudflare deploy.
I switched it to the same token-based workflow the docs repo uses: it runs on every push to main with
GITHUB_TOKEN, takes its config from the org.githubrepo, and keeps av0.1.0-rc.1draft (0.x until 1.0, rc first). The changelog-commit step went with the App, since it needed the App token to push to main.Closes #9
Verification
How this was verified
Ran actionlint on the workflow locally; it's byte-for-byte the docs repo's workflow, which already keeps that repo's
v0.1.0-rc.1draft. After merge I'll check the draft shows up here.