Repository navigation
docs(fleet-manager): the Protocols page now switches per node - #96
Merged
Merged
Conversation
cryptos-web#165 rebuilt the manager's Protocols page on each node's reported ACME/EST state and wired its switch to SetNodeProtocol, replacing the fleet-wide catalog that only recorded intent. Update the web UI and overview pages to match: the list counts nodes actually serving each protocol, the detail page switches one node and explains why an ineligible node has no switch, and SCEP/Windows autoenrollment are described as not wired up rather than as an inert toggle. Drops the stale "known gap" line about the protocol page saving only Enabled -- the old bound-profile/endpoint/challenge fields are gone along with the catalog they edited. Refs CryptOS-PKI/cryptos-manager#84 Signed-off-by: Bugs5382 <12115015+Bugs5382@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
CryptOS-PKI/cryptos-web@PR#165 rebuilt the Fleet Manager's Protocols page on
each node's reported ACME/EST state (
NodeSummary.protocols) and wired itsswitch to
SetNodeProtocol, replacing the fleet-wide mock catalog that onlyrecorded intent and showed zero protocols on a live fleet. This updates the
two docs pages that described the old behavior:
docs/fleet-manager/web-ui.md(Protocols section and the "Known gaps"list): the list page now counts nodes actually serving each protocol and
waiting on a reboot; the detail page switches one node and explains why an
ineligible node (wrong role, or not yet ESTABLISHED) has no switch; SCEP and
Windows autoenrollment are described as not wired up (no node config block)
rather than as an inert toggle. Drops the stale gap note about the page
saving only "Enabled" -- the bound-profile/endpoint/challenge fields it
referred to are gone along with the mock catalog they edited.
docs/fleet-manager/overview.md("Switching an enrolment protocol on anode" and "What is not available today"): says the web UI now calls
SetNodeProtocol, where it previously said the page didn't use it yet.No change to the "Known gaps" list's other bullets, the MCP/approvals text
about
SetAdapterEnabled(that RPC and its admin gate are unchanged and stillaccurate), or anything about SCEP/Windows autoenrollment's build status.
Refs CryptOS-PKI/cryptos-manager#84
Verification
How this was verified
npm run build(docusaurus build): generated static files with no MDXerrors.
cryptos-webPR's behavior(list/detail page content, SetNodeProtocol wiring, SCEP/Windows
autoenrollment "not wired up" messaging) rather than only checking prose
style.