Repository navigation
Commit e3bc83a
committed
fix: dispose the text the charts lay out
A laid-out TextPainter holds a native paragraph and has to be disposed.
None of them were, and a chart lays out a few dozen labels a frame: over
eight thousand painters were left to the garbage collector across the test
suite alone.
TextPainterCache now disposes the painter it evicts, the ones clear()
drops and everything it still holds when the new dispose() is called; all
39 charts that own a cache dispose it with their state. The depth chart
was laying out every label afresh on every paint and throwing the painters
away — it goes through a cache like every other chart. The painters that
cannot be cached, because the cache keys on a plain string — a multi-span
legend row, an axis label, a marker label, an event glyph in its own icon
font — are disposed as soon as they are painted.
KChartWidget also disposes the CurvedAnimation wrapping each scroll
animation, rather than leaving one behind per fling.
The suite runs under leak_tracker from here on, so a widget that leaves a
disposable behind fails its file. The two ChangeNotifiers the caller owns,
ChartDrawingController and KChartController, are left out of it: the chart
attaches and detaches but never disposes what it did not make.1 parent f079f21 commit e3bc83a
47 files changed
Lines changed: 264 additions & 18 deletions
File tree
- lib/src
- book
- bubble
- bullet
- calendar
- chord
- delta
- distribution
- dumbbell
- equity
- footprint
- funnel
- gauge
- liquidity
- marimekko
- openinterest
- options
- pairs
- parallel
- pie
- profile
- radar
- renderer
- sankey
- series
- slope
- sparkline
- stream
- sunburst
- timeline
- treemap
- violin
- volatility
- waterfall
- test
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
455 | 455 | | |
456 | 456 | | |
457 | 457 | | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
458 | 465 | | |
459 | 466 | | |
460 | 467 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
397 | 397 | | |
398 | 398 | | |
399 | 399 | | |
| 400 | + | |
400 | 401 | | |
401 | 402 | | |
402 | 403 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
405 | 405 | | |
406 | 406 | | |
407 | 407 | | |
| 408 | + | |
408 | 409 | | |
409 | 410 | | |
410 | 411 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
545 | 545 | | |
546 | 546 | | |
547 | 547 | | |
| 548 | + | |
548 | 549 | | |
549 | 550 | | |
550 | 551 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
537 | 537 | | |
538 | 538 | | |
539 | 539 | | |
| 540 | + | |
540 | 541 | | |
541 | 542 | | |
542 | 543 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
503 | 503 | | |
504 | 504 | | |
505 | 505 | | |
| 506 | + | |
506 | 507 | | |
507 | 508 | | |
508 | 509 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
| |||
102 | 103 | | |
103 | 104 | | |
104 | 105 | | |
| 106 | + | |
105 | 107 | | |
106 | 108 | | |
107 | 109 | | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
108 | 116 | | |
109 | 117 | | |
110 | 118 | | |
| |||
151 | 159 | | |
152 | 160 | | |
153 | 161 | | |
| 162 | + | |
154 | 163 | | |
155 | 164 | | |
156 | 165 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
490 | 490 | | |
491 | 491 | | |
492 | 492 | | |
| 493 | + | |
493 | 494 | | |
494 | 495 | | |
495 | 496 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
367 | 367 | | |
368 | 368 | | |
369 | 369 | | |
| 370 | + | |
370 | 371 | | |
371 | 372 | | |
372 | 373 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
426 | 426 | | |
427 | 427 | | |
428 | 428 | | |
| 429 | + | |
429 | 430 | | |
430 | 431 | | |
431 | 432 | | |
| |||
0 commit comments