Conversation
PavelAF
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #344.
openvswitch.pycurrently appliesovs_optionsbefore the bridge update path clears the existing OVSother_config. As a result, options configured in/etc/network/interfacescan be removed duringifreload.This changes the update order so that stale bridge configuration is cleared first and the configured
ovs_optionsare applied afterwards.Reproducer
Given a bridge with an option such as:
running:
should preserve the configured option.
Before this change, the option may be removed during reload. After this change, it remains configured as expected.
See #344 for the full bug report and reproduction details.