Update a snapshot in cyclonedx-bom-macros for Rust 1.91 - #810
Update a snapshot in cyclonedx-bom-macros for Rust 1.91#810musicinmybrain wants to merge 1 commit into
Conversation
Signed-off-by: Benjamin A. Beasley <code@musicinmybrain.net>
|
Hmm. This does make --- expected 2025-12-06 09:14:33.221846240 +0000
+++ actual 2025-12-06 09:14:46.189919528 +0000
@@ -1,7 +1,7 @@
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈
error[E0428]: the name `Foo` is defined multiple times
- --> tests/ui/fail/duplicated_struct.rs:10:5
- |
+ --> tests/ui/fail/duplicated_struct.rs:10:5
+ |
7 | pub struct Foo;
| --------------- previous definition of the type `Foo` here
... |
Shnatsel
left a comment
There was a problem hiding this comment.
In the long run we shouldn't depend on the human-readable output, but I'm happy to have a quick fix right now. Thanks!
Shnatsel
left a comment
There was a problem hiding this comment.
Sadly I don't think this is workable as-is because we run CI both on the minimum supported Rust version and the latest version; I think we need to stop checking for exact match in the output on this test.
That makes sense. It would be better for me as a downstream packager anyway, since (as described in #810 (comment)) this test still seems to be brittle and sensitive to the surrounding environment even on a particular Rust toolchain version. |
|
@musicinmybrain Is this something you'd like to provide a PR for? (no pressure, just checking) |
Probably not: since sensitivity to precise compiler output is an idea that is fundamental to |
|
The proper way to fix this is to migrate away from I've opened #823 to work around this in the short term. Closing in favor of that PR. |
Based on testing in Fedora with Rust 1.91.1, while packaging this as a new dependency for https://github.com/astral-sh/uv.