Use response instead of responses when serializing VulnerabilityAnalysis - #869
Open
Naxdy wants to merge 1 commit into
Open
Use response instead of responses when serializing VulnerabilityAnalysis#869Naxdy wants to merge 1 commit into
response instead of responses when serializing VulnerabilityAnalysis#869Naxdy wants to merge 1 commit into
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | -2 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Contributor
|
Ah, that's a typo on our end. Thanks! |
…Analysis` Signed-off-by: Naxdy <naxdy@naxdy.org>
Author
|
I only tested with JSON (not XML), but the tests pass at least |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec actually names this
response(singular) as opposed toresponses(plural). Tools like Dependency Track also use the singularresponse, despite the fact that it describes an array.See: https://cyclonedx.org/docs/1.5/json/#vulnerabilities_items_analysis_response