Repository navigation
fix(helper): restore preloading after clearing adapters - #6827
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
clearBeforeAdapters()andclearAfterAdapters()remove their load-more attach listeners from the header/footer adapters, but never put the listeners back on the content adapter. Consequently, clearing the decorations also silently disables leading/trailing preloading.For example, build a helper with a trailing listener and
setTrailPreloadSize(2), add a footer, attachhelper.adapterto a RecyclerView, then callclearAfterAdapters(). WithtrailingLoadState = LoadState.NotLoading(false), scrolling to the final content rows never invokesonLoad(). The leading/header case has the same cause.Restore the existing listener to the content adapter after each clear, matching the listener ownership used when no headers/footers are present. No API, load-state defaults or dependencies of the shipped library change.
Validation
./gradlew :library:compileDebugKotlin testpasses (JDK 17; target-pinned RecyclerView 1.4.0 / Kotlin 2.3.21).git diff --checkpasses.No physical device, emulator or visual acceptance was performed; the reproduction is an isolated JVM/Robolectric test. No sample-app UI change.