drm: spacemit: port K3 display driver to 7.4 DRM atomic state API

The K3 display v2 series targets the legacy DRM CRTC/plane reset
callbacks, which were removed in the 7.4 kernel in favor of the
atomic_create_state() hooks.

- spacemit_crtc.c: replace .reset with .atomic_create_state and
  create the initial state with drm_mode_config_create_initial_state()
  before drm_dev_register().
- spacemit_planes.c: replace .reset with .atomic_create_state,
  using __drm_atomic_helper_plane_state_init().

Also fix a mangled dev_err() format string introduced during the port.

Author: sandiecao-dc

drivers/gpu/drm/spacemit/spacemit_crtc.c

@@ -273,29 +273,27 @@ static void spacemit_crtc_destroy_state(struct drm_crtc *crtc,
 	}
 }
 
-static void spacemit_crtc_reset(struct drm_crtc *crtc)
+static struct drm_crtc_state *
+spacemit_crtc_create_state(struct drm_crtc *crtc)
 {
 	struct spacemit_drm_private *priv = crtc->dev->dev_private;
 	struct spacemit_hw_device *hwdev = priv->hwdev;
 	struct spacemit_crtc_state *state;
 
-	if (crtc->state)
-		spacemit_crtc_destroy_state(crtc, crtc->state);
-
 	state = kzalloc_obj(*state);
-	if (!state) {
-		__drm_atomic_helper_crtc_reset(crtc, NULL);
-		return;
-	}
+	if (!state)
+		return ERR_PTR(-ENOMEM);
 
 	state->rdmas = kzalloc_objs(*state->rdmas, hwdev->rdma_nums);
 	if (!state->rdmas) {
 		kfree(state);
-		__drm_atomic_helper_crtc_reset(crtc, NULL);
-		return;
+		return ERR_PTR(-ENOMEM);
 	}
 
-	__drm_atomic_helper_crtc_reset(crtc, &state->base);
+	state->cl.type = CMDLIST_CRTC;
+	__drm_atomic_helper_crtc_state_init(&state->base, crtc);
+
+	return &state->base;
 }
 
 static int spacemit_crtc_enable_vblank(struct drm_crtc *crtc)
@@ -332,7 +330,7 @@ static const struct drm_crtc_funcs spacemit_crtc_funcs = {
 	.destroy = drm_crtc_cleanup,
 	.set_config = drm_atomic_helper_set_config,
 	.page_flip = drm_atomic_helper_page_flip,
-	.reset = spacemit_crtc_reset,
+	.atomic_create_state = spacemit_crtc_create_state,
 	.atomic_duplicate_state = spacemit_crtc_duplicate_state,
 	.atomic_destroy_state = spacemit_crtc_destroy_state,
 	.enable_vblank = spacemit_crtc_enable_vblank,
@@ -590,6 +588,12 @@ static int spacemit_drm_master_bind(struct device *dev)
 	drmm_kms_helper_poll_init(drm);
 	drm_helper_hpd_irq_event(drm);
 
+	ret = drm_mode_config_create_initial_state(drm);
+	if (ret) {
+		dev_err(dev, "failed to create initial state: %d\n", ret);
+		goto err_unbind_all;
+	}
+
 	enable_irq(priv->irq_online);
 
 	ret = drm_dev_register(drm, 0);

drivers/gpu/drm/spacemit/spacemit_planes.c

@@ -209,20 +209,19 @@ static void spacemit_plane_atomic_disable(struct drm_plane *plane,
 	drm_dev_exit(idx);
 }
 
-static void spacemit_plane_reset(struct drm_plane *plane)
+static struct drm_plane_state *
+spacemit_plane_create_state(struct drm_plane *plane)
 {
 	struct spacemit_plane_state *s;
 
-	if (plane->state) {
-		spacemit_plane_atomic_destroy_state(plane, plane->state);
-		plane->state = NULL;
-	}
-
 	s = kzalloc(sizeof(*s), GFP_KERNEL);
-	if (s) {
-		__drm_atomic_helper_plane_reset(plane, &s->state);
-		s->rdma_id = RDMA_INVALID_ID;
-	}
+	if (!s)
+		return ERR_PTR(-ENOMEM);
+
+	__drm_atomic_helper_plane_state_init(&s->state, plane);
+	s->rdma_id = RDMA_INVALID_ID;
+
+	return &s->state;
 }
 
 static struct drm_plane_state *
@@ -304,7 +303,7 @@ static const struct drm_plane_funcs spacemit_plane_funcs = {
 	.update_plane = drm_atomic_helper_update_plane,
 	.disable_plane	= drm_atomic_helper_disable_plane,
 	.destroy = drm_plane_cleanup,
-	.reset = spacemit_plane_reset,
+	.atomic_create_state = spacemit_plane_create_state,
 	.atomic_duplicate_state = spacemit_plane_atomic_duplicate_state,
 	.atomic_destroy_state = spacemit_plane_atomic_destroy_state,
 };