fix(types): resolve all project build errors in tsc -b

- Safely resolve slot models via get_agent_slot_model in useAgentConfig to eliminate TS18048 undefined checks
- Normalize model configs to strictly typed ModelConfigDto in normalizers.ts to eliminate TS2322
- Correct AgentDto import path to contracts/agent in agent_telemetry_store to eliminate TS2305
- Add required category field to Agent mock fixtures in agent_mappers.test.ts to eliminate TS2741

Author: DDS-Solutions

src/components/agent-config/useAgentConfig.ts

@@ -16,7 +16,7 @@ import { tadpole_os_service } from '../../services/tadpoleos_service';
 import { event_bus } from '../../services/event_bus';
 import { use_role_store } from '../../stores/role_store';
 import { use_model_store } from '../../stores/model_store';
-import { resolve_agent_model_config, resolve_technical_model_id } from '../../utils/model_utils';
+import { resolve_agent_model_config, resolve_technical_model_id, get_agent_slot_model } from '../../utils/model_utils';
 import { ValidationUtils } from '../../utils/validation_utils';
 import { i18n } from '../../i18n';
 import type { Agent, AgentPatch, Role_Definition, Agent_Model_Slot_Key, Department } from '../../contracts/agent';
@@ -59,12 +59,12 @@ export function useAgentConfig(
         last_seen_agent_ref.current = agent;
 
         // Skip rehydration if the parent/external store didn't update the agent structurally
-        const last_m1 = last_seen.model_config?.modelId || (last_seen.model_config as unknown as { model_id?: string })?.model_id;
-        const curr_m1 = agent.model_config?.modelId || (agent.model_config as unknown as { model_id?: string })?.model_id;
-        const last_m2 = last_seen.model_config2?.modelId || (last_seen.model_config2 as unknown as { model_id?: string })?.model_id;
-        const curr_m2 = agent.model_config2?.modelId || (agent.model_config2 as unknown as { model_id?: string })?.model_id;
-        const last_m3 = last_seen.model_config3?.modelId || (last_seen.model_config3 as unknown as { model_id?: string })?.model_id;
-        const curr_m3 = agent.model_config3?.modelId || (agent.model_config3 as unknown as { model_id?: string })?.model_id;
+        const last_m1 = get_agent_slot_model(last_seen, 1);
+        const curr_m1 = get_agent_slot_model(agent, 1);
+        const last_m2 = get_agent_slot_model(last_seen, 2);
+        const curr_m2 = get_agent_slot_model(agent, 2);
+        const last_m3 = get_agent_slot_model(last_seen, 3);
+        const curr_m3 = get_agent_slot_model(agent, 3);
 
         if (last_seen &&
             last_seen.id === agent.id &&

src/contracts/agent/domain.ts

@@ -11,10 +11,10 @@
  */
 
 import type { ModelConfigDto } from './wire';
-import type { 
-    Agent_Status, 
-    Department, 
-    Agent_Metadata, 
+import type {
+    Agent_Status,
+    Department,
+    Agent_Metadata,
     Agent_Connector_Config,
     Agent_Voice_Engine,
     Agent_Stt_Engine
@@ -29,7 +29,7 @@ export interface Agent {
     status: Agent_Status;
     tokens_used?: number;
     current_task?: string;
-    model: string; 
+    model: string;
     model_2?: string;
     model_3?: string;
     model_config?: ModelConfigDto;
@@ -52,15 +52,15 @@ export interface Agent {
     output_tokens?: number;
     failure_count?: number;
     last_failure_at?: string;
-    category: string; 
+    category: string;
     connector_configs?: Agent_Connector_Config[];
     metadata?: Agent_Metadata;
     current_reasoning_turn?: number;
     reasoning_depth?: number;
     workspace_path?: string;
     _local_timestamp?: number;
     _telemetry_timestamp?: number;
-    active_mission?: { 
+    active_mission?: {
         id: string;
         objective?: string;
         constraints?: string[];
@@ -103,41 +103,41 @@ export interface Agent_Memory_Entry {
  * Represents a unit of work assigned to an agent.
  */
 export interface Task {
-  id: string;
-  title: string;
-  assigned_to: string;
-  status: 'pending' | 'in-progress' | 'completed' | 'failed';
-  priority: 'low' | 'medium' | 'high';
-  created_at: string;
-  logs: string[];
+    id: string;
+    title: string;
+    assigned_to: string;
+    status: 'pending' | 'in-progress' | 'completed' | 'failed';
+    priority: 'low' | 'medium' | 'high';
+    created_at: string;
+    logs: string[];
 }
 
 /**
  * Task_Payload
  * Payload for sending a command/task to an agent.
  */
 export interface Task_Payload {
-  message: string;
-  cluster_id?: string;
-  department?: string;
-  provider?: string;
-  model_id?: string;
-  api_key?: string;
-  base_url?: string;
-  rpm?: number;
-  tpm?: number;
-  rpd?: number;
-  tpd?: number;
-  budget_usd?: number;
-  external_id?: string;
-  safe_mode?: boolean;
-  analysis?: boolean;
-  swarm_depth?: number;
-  swarm_lineage?: string[];
-  recent_findings?: string;
-  traceparent?: string;
-  parent_node_id?: string;
-  enabled_skills?: string[];
+    message: string;
+    cluster_id?: string;
+    department?: string;
+    provider?: string;
+    model_id?: string;
+    api_key?: string;
+    base_url?: string;
+    rpm?: number;
+    tpm?: number;
+    rpd?: number;
+    tpd?: number;
+    budget_usd?: number;
+    external_id?: string;
+    safe_mode?: boolean;
+    analysis?: boolean;
+    swarm_depth?: number;
+    swarm_lineage?: string[];
+    recent_findings?: string;
+    traceparent?: string;
+    parent_node_id?: string;
+    enabled_skills?: string[];
 }
 
 export type AgentPatch = Partial<Agent>;

src/domain/agents/normalizers.ts

@@ -13,6 +13,7 @@
 import type { 
     Agent, 
     AgentDto, 
+    ModelConfigDto,
     Department, 
     Agent_Status,
     Agent_Memory_Entry,
@@ -23,6 +24,19 @@ import type {
 import { resolve_friendly_model_name } from '../../utils/model_utils';
 import { get_settings } from '../../stores/settings_store';
 import { use_trace_store } from '../../stores/trace_store';
+
+const normalize_model_config = (raw: unknown, default_model_id?: string): ModelConfigDto | undefined => {
+    if (!raw || typeof raw !== 'object') return undefined;
+    const cfg = raw as Record<string, unknown>;
+    const modelId = (cfg.modelId || cfg.model_id || cfg.model || default_model_id) as string | undefined;
+    if (!modelId || modelId === 'unknown') return undefined;
+    const provider = (cfg.provider as string | undefined) || 'ollama';
+    return {
+        ...cfg,
+        provider,
+        modelId,
+    } as ModelConfigDto;
+};
 import { v4 as uuidv4 } from 'uuid';
 
 
@@ -154,6 +168,20 @@ export const normalize_agent_dto = (dto: AgentDto, workspace_path?: string, exis
         || default_model;
     const model = resolve_friendly_model_name(raw_model) || raw_model;
 
+    const cfg2 = get_val('modelConfig2', 'model_config2', undefined) as Record<string, unknown> | undefined;
+    const m2_config_id = (cfg2?.modelId || cfg2?.model_id || cfg2?.model) as string | undefined;
+    const m2_name = get_val<string | undefined>('model2', 'model_2', undefined);
+    const raw_m2 = (m2_config_id && m2_config_id !== 'unknown' ? m2_config_id : undefined)
+        || (m2_name && m2_name !== 'unknown' ? m2_name : undefined);
+    const model_2 = raw_m2 ? (resolve_friendly_model_name(raw_m2) || raw_m2) : undefined;
+
+    const cfg3 = get_val('modelConfig3', 'model_config3', undefined) as Record<string, unknown> | undefined;
+    const m3_config_id = (cfg3?.modelId || cfg3?.model_id || cfg3?.model) as string | undefined;
+    const m3_name = get_val<string | undefined>('model3', 'model_3', undefined);
+    const raw_m3 = (m3_config_id && m3_config_id !== 'unknown' ? m3_config_id : undefined)
+        || (m3_name && m3_name !== 'unknown' ? m3_name : undefined);
+    const model_3 = raw_m3 ? (resolve_friendly_model_name(raw_m3) || raw_m3) : undefined;
+
     const input_tokens = (dto.tokenUsage?.inputTokens ?? d.input_tokens ?? existing_agent?.input_tokens ?? 0);
     const output_tokens = (dto.tokenUsage?.outputTokens ?? d.output_tokens ?? existing_agent?.output_tokens ?? 0);
     const tokens_used = (dto.tokenUsage?.totalTokens ?? d.tokensUsed ?? d.tokens_used ?? (input_tokens + output_tokens));
@@ -167,14 +195,7 @@ export const normalize_agent_dto = (dto: AgentDto, workspace_path?: string, exis
         status: status,
         tokens_used,
         model: model,
-        model_config: (() => {
-            const cfg = get_val('modelConfig', 'model_config', undefined) as Record<string, unknown> | undefined;
-            if (!cfg) return undefined;
-            if (!cfg.modelId && cfg.model_id) {
-                return { ...cfg, modelId: cfg.model_id };
-            }
-            return cfg;
-        })(),
+        model_config: normalize_model_config(cfg1, raw_model),
         workspace_path: workspace_path || get_val('workspace', 'workspace_path', undefined),
         current_task: current_task || undefined,
         skills: parse_json_array('skills', 'skills'),
@@ -184,38 +205,10 @@ export const normalize_agent_dto = (dto: AgentDto, workspace_path?: string, exis
         budget_usd: get_val('budgetUsd', 'budget_usd', 0),
         cost_usd: get_val('costUsd', 'cost_usd', 0),
         requires_oversight: get_val('requiresOversight', 'requires_oversight', false),
-        model_2: (() => {
-            const cfg2 = get_val('modelConfig2', 'model_config2', undefined) as Record<string, unknown> | undefined;
-            const m2_config_id = (cfg2?.modelId || cfg2?.model_id || cfg2?.model) as string | undefined;
-            const m2_name = get_val<string | undefined>('model2', 'model_2', undefined);
-            const raw_m2 = (m2_config_id && m2_config_id !== 'unknown' ? m2_config_id : undefined)
-                || (m2_name && m2_name !== 'unknown' ? m2_name : undefined);
-            return raw_m2 ? (resolve_friendly_model_name(raw_m2) || raw_m2) : undefined;
-        })(),
-        model_3: (() => {
-            const cfg3 = get_val('modelConfig3', 'model_config3', undefined) as Record<string, unknown> | undefined;
-            const m3_config_id = (cfg3?.modelId || cfg3?.model_id || cfg3?.model) as string | undefined;
-            const m3_name = get_val<string | undefined>('model3', 'model_3', undefined);
-            const raw_m3 = (m3_config_id && m3_config_id !== 'unknown' ? m3_config_id : undefined)
-                || (m3_name && m3_name !== 'unknown' ? m3_name : undefined);
-            return raw_m3 ? (resolve_friendly_model_name(raw_m3) || raw_m3) : undefined;
-        })(),
-        model_config2: (() => {
-            const cfg2 = get_val('modelConfig2', 'model_config2', undefined) as Record<string, unknown> | undefined;
-            if (!cfg2) return undefined;
-            const m2_id = cfg2.modelId || cfg2.model_id || cfg2.model;
-            if (!m2_id || m2_id === 'unknown') return undefined;
-            if (!cfg2.modelId && cfg2.model_id) return { ...cfg2, modelId: cfg2.model_id };
-            return cfg2;
-        })(),
-        model_config3: (() => {
-            const cfg3 = get_val('modelConfig3', 'model_config3', undefined) as Record<string, unknown> | undefined;
-            if (!cfg3) return undefined;
-            const m3_id = cfg3.modelId || cfg3.model_id || cfg3.model;
-            if (!m3_id || m3_id === 'unknown') return undefined;
-            if (!cfg3.modelId && cfg3.model_id) return { ...cfg3, modelId: cfg3.model_id };
-            return cfg3;
-        })(),
+        model_2,
+        model_3,
+        model_config2: normalize_model_config(cfg2, raw_m2),
+        model_config3: normalize_model_config(cfg3, raw_m3),
         active_model_slot: (get_val('activeModelSlot', 'active_model_slot', 1) as 1 | 2 | 3),
         failure_count: get_val('failureCount', 'failure_count', 0),
         last_failure_at: get_val('lastFailureAt', 'last_failure_at', undefined),

src/services/agent_mappers.test.ts

@@ -211,6 +211,7 @@ describe('agent_mappers', () => {
                 model_2: 'claude-3-5-sonnet',
                 model_config2: { modelId: 'claude-3-5-sonnet', provider: 'anthropic', temperature: 0.5 },
                 active_model_slot: 2,
+                category: 'general',
                 skills: [],
                 workflows: []
             };
@@ -235,6 +236,7 @@ describe('agent_mappers', () => {
                 model: 'Gemini 1.5 Flash',
                 model_config: { modelId: 'gemini-1.5-flash', provider: 'google', temperature: 0.7 },
                 active_model_slot: 1,
+                category: 'general',
                 skills: [],
                 workflows: []
             };

src/stores/agent_telemetry_store.ts

@@ -18,7 +18,7 @@
 import { create } from 'zustand';
 import { tadpole_os_socket } from '../services/socket';
 import { use_agent_registry_store } from './agent_registry_store';
-import type { Agent, AgentDto } from '../types';
+import type { Agent, AgentDto } from '../contracts/agent';
 import { normalize_agent_dto } from '../domain/agents/normalizers';
 
 export interface Telemetry_State {