Conversation
- Remove committed monitoring/prometheus/bearer_token and gitignore it - Replace bearer_token.example with a non-secret placeholder - Require GRAFANA_ADMIN_PASSWORD (no admin default) - Allowlist MCP skill subprocess env (exclude provider/API tokens) - Set USE_SANDBOX_DOCKER=true in .env.example to match README guidance - Add unit coverage for MCP env allowlisting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
High-priority security hygiene from a code review of
main:monitoring/prometheus/bearer_token(containedtest-token), replacedbearer_token.examplewith a non-secret placeholder, and gitignored the real file.docker-compose.ymlnow requiresGRAFANA_ADMIN_PASSWORD(same fail-fast pattern asNEURAL_TOKEN); removed theadmindefault.execution/tadpole_mcp_server.pyno longer passesos.environ.copy()into legacy skill subprocesses; uses an allowlist that excludes provider API keys andNEURAL_TOKEN*. Unit coverage added intests/unit/test_mcp_sandbox.py..env.examplesetsUSE_SANDBOX_DOCKER=trueto match README guidance while keepingALLOW_HOST_SKILL_EXECUTION=false. DocumentsGRAFANA_ADMIN_PASSWORD.Notes
test-tokenasNEURAL_TOKEN, rotate it.cp monitoring/prometheus/bearer_token.example monitoring/prometheus/bearer_tokenand paste the real token locally.GRAFANA_ADMIN_PASSWORDin.env.Test plan
python -m unittest discover -s tests/unit -p 'test_mcp_sandbox.py'monitoring/prometheus/bearer_tokenis absent from the treedocker compose configfails withoutGRAFANA_ADMIN_PASSWORDand succeeds when set.env.examplesandbox defaults