Conversation
Replace root_element.innerHTML interpolation of String(err) with DOM APIs and textContent so exception messages cannot inject HTML/JS. Wire the reset button via addEventListener instead of an inline onclick handler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the medium XSS sink in
src/main.tsx: the React mount failure fallback interpolatedString(err)intoinnerHTML.Now it builds the fault UI with
createElement/textContentand attaches the reset button withaddEventListener(no inlineonclick, no HTML string interpolation).Test plan
App) and confirm the fault screen still renders<img src=x onerror=alert(1)>shows literally)localStorageand reloads