Skip to content

feat: impl ghost contract [ISSUE-7] - #13

Open
pingoo33 wants to merge 1 commit into
DE-labtory:developfrom
pingoo33:develop
Open

feat: impl ghost contract [ISSUE-7]#13
pingoo33 wants to merge 1 commit into
DE-labtory:developfrom
pingoo33:develop

Conversation

@pingoo33

@pingoo33 pingoo33 commented May 7, 2019

Copy link
Copy Markdown

Related Issue

resolve: #7

Description

implement ghost contract

Checklist

Thank you for your contribution.
Before submitting this PR, please make sure:

  • Applying goimports
  • Test case
  • End of Work

Comment thread ethereum/GhostFactory.sol Outdated
Comment thread ethereum/GhostFactory.sol Outdated

@hihiboss hihiboss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments!

And, I'm not sure, but using comment like /// @dev or ///@param might be the convention of solidity.
So, if you can, please write comments with solidity comment style.

Comment thread ethereum/GhostFactory.sol Outdated
Comment thread ethereum/GhostFactory.sol Outdated
Comment thread ethereum/GhostFactory.sol Outdated
Comment thread ethereum/GhostFactory.sol Outdated
Comment thread ethereum/GhostFactory.sol Outdated
Comment thread ethereum/GhostOwnership.sol Outdated
Comment thread ethereum/GhostOwnership.sol Outdated
Comment thread ethereum/GhostOwnership.sol Outdated
Comment thread ethereum/GhostOwnership.sol Outdated
Comment thread ethereum/GhostOwnership.sol Outdated
@pingoo33
pingoo33 force-pushed the develop branch 2 times, most recently from b1eb5e4 to c21c9eb Compare May 11, 2019 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[eth] ghost contract bootstrap

3 participants