Skip to content

Commit 18bde79

Browse files
authored
Merge pull request #6072 from tdonohue/fix_docker_tags
[Docker] Update `dspace-10_x` branch to use the `dspace-10_x` Docker tags in all Docker Compose scripts
2 parents e00c9dc + 3d67acb commit 18bde79

8 files changed

Lines changed: 14 additions & 14 deletions

Dockerfile.dist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# See https://github.com/DSpace/dspace-angular/tree/main/docker for usage details
33

44
# Test build:
5-
# docker build -f Dockerfile.dist -t dspace/dspace-angular:latest-dist .
5+
# docker build -f Dockerfile.dist -t dspace/dspace-angular:dspace-10_x-dist .
66

77
# Step 1 - Build code for production
88
FROM docker.io/node:22-alpine AS build

docker/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,23 +24,23 @@ This Dockerfile is used to build a *development* mode DSpace Angular UI image, p
2424
when local source code is modified.
2525

2626
```
27-
docker build -t dspace/dspace-angular:latest .
27+
docker build -t dspace/dspace-angular:dspace-10_x .
2828
```
2929

3030
This image is built *automatically* after each commit is made to the `main` branch.
3131

3232
Admins to our DockerHub repo can manually publish with the following command.
3333
```
34-
docker push dspace/dspace-angular:latest
34+
docker push dspace/dspace-angular:dspace-10_x
3535
```
3636

3737
### Dockerfile.dist
3838

3939
The `Dockerfile.dist` is used to build a *production* mode DSpace Angular UI image, published as 'dspace/dspace-angular' with a `*-dist` tag. Because it uses production mode, this image supports Server Side Rendering (SSR).
4040

4141
```bash
42-
# build the latest image
43-
docker build -f Dockerfile.dist -t dspace/dspace-angular:latest-dist .
42+
# build the 10.x image
43+
docker build -f Dockerfile.dist -t dspace/dspace-angular:dspace-10_x-dist .
4444
```
4545

4646
A default/demo version of this image is built *automatically*.

docker/cli.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ networks:
2121
external: true
2222
services:
2323
dspace-cli:
24-
image: "${DOCKER_REGISTRY:-docker.io}/${DOCKER_OWNER:-dspace}/dspace-cli:${DSPACE_VER:-latest}"
24+
image: "${DOCKER_REGISTRY:-docker.io}/${DOCKER_OWNER:-dspace}/dspace-cli:${DSPACE_VER:-dspace-10_x}"
2525
container_name: dspace-cli
2626
environment:
2727
# Below syntax may look odd, but it is how to override dspace.cfg settings via env variables.

docker/db.entities.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
# # Therefore, it should be kept in sync with that file
1515
services:
1616
dspacedb:
17-
image: "${DOCKER_REGISTRY:-docker.io}/${DOCKER_OWNER:-dspace}/dspace-postgres-loadsql:${DSPACE_VER:-latest}"
17+
image: "${DOCKER_REGISTRY:-docker.io}/${DOCKER_OWNER:-dspace}/dspace-postgres-loadsql:${DSPACE_VER:-dspace-10_x}"
1818
environment:
1919
# This LOADSQL should be kept in sync with the URL in DSpace/DSpace
2020
# This SQL is available from https://github.com/DSpace-Labs/AIP-Files/releases/tag/demo-entities-data

docker/docker-compose-ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ services:
3333
# This allows us to generate statistics in e2e tests so that statistics pages can be tested thoroughly.
3434
solr__D__statistics__P__autoCommit: ${solr__D__statistics__P__autoCommit:-false}
3535
LOGGING_CONFIG: ${LOGGING_CONFIG:-/dspace/config/log4j2-container.xml}
36-
image: "${DOCKER_REGISTRY:-docker.io}/${DOCKER_OWNER:-dspace}/dspace:${DSPACE_VER:-latest-test}"
36+
image: "${DOCKER_REGISTRY:-docker.io}/${DOCKER_OWNER:-dspace}/dspace:${DSPACE_VER:-dspace-10_x-test}"
3737
depends_on:
3838
- dspacedb
3939
networks:
@@ -58,7 +58,7 @@ services:
5858
# NOTE: This is customized to use our loadsql image, so that we are using a database with existing test data
5959
dspacedb:
6060
container_name: dspacedb
61-
image: "${DOCKER_REGISTRY:-docker.io}/${DOCKER_OWNER:-dspace}/dspace-postgres-loadsql:${DSPACE_VER:-latest}"
61+
image: "${DOCKER_REGISTRY:-docker.io}/${DOCKER_OWNER:-dspace}/dspace-postgres-loadsql:${DSPACE_VER:-dspace-10_x}"
6262
environment:
6363
# This LOADSQL should be kept in sync with the LOADSQL in
6464
# https://github.com/DSpace/DSpace/blob/main/dspace/src/main/docker-compose/db.entities.yml
@@ -79,7 +79,7 @@ services:
7979
# DSpace Solr container
8080
dspacesolr:
8181
container_name: dspacesolr
82-
image: "${DOCKER_REGISTRY:-docker.io}/${DOCKER_OWNER:-dspace}/dspace-solr:${DSPACE_VER:-latest}"
82+
image: "${DOCKER_REGISTRY:-docker.io}/${DOCKER_OWNER:-dspace}/dspace-solr:${DSPACE_VER:-dspace-10_x}"
8383
networks:
8484
- dspacenet
8585
ports:

docker/docker-compose-dist.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ services:
2929
DSPACE_REST_NAMESPACE: ${DSPACE_REST_NAMESPACE:-/server}
3030
# Ensure SSR can use the 'dspace' Docker image directly (see docker-compose-rest.yml)
3131
DSPACE_REST_SSRBASEURL: ${DSPACE_REST_SSRBASEURL:-http://dspace:8080/server}
32-
image: "${DOCKER_REGISTRY:-docker.io}/${DOCKER_OWNER:-dspace}/dspace-angular:${DSPACE_VER:-latest}-dist"
32+
image: "${DOCKER_REGISTRY:-docker.io}/${DOCKER_OWNER:-dspace}/dspace-angular:${DSPACE_VER:-dspace-10_x}-dist"
3333
build:
3434
context: ..
3535
dockerfile: Dockerfile.dist

docker/docker-compose-rest.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ services:
4848
# from the host machine. This IP range MUST correspond to the 'dspacenet' subnet defined above.
4949
proxies__P__trusted__P__ipranges: ${proxies__P__trusted__P__ipranges:-172.23.0}
5050
LOGGING_CONFIG: ${LOGGING_CONFIG:-/dspace/config/log4j2-container.xml}
51-
image: "${DOCKER_REGISTRY:-docker.io}/${DOCKER_OWNER:-dspace}/dspace:${DSPACE_VER:-latest-test}"
51+
image: "${DOCKER_REGISTRY:-docker.io}/${DOCKER_OWNER:-dspace}/dspace:${DSPACE_VER:-dspace-10_x-test}"
5252
depends_on:
5353
- dspacedb
5454
networks:
@@ -91,7 +91,7 @@ services:
9191
# DSpace Solr container
9292
dspacesolr:
9393
container_name: dspacesolr
94-
image: "${DOCKER_REGISTRY:-docker.io}/${DOCKER_OWNER:-dspace}/dspace-solr:${DSPACE_VER:-latest}"
94+
image: "${DOCKER_REGISTRY:-docker.io}/${DOCKER_OWNER:-dspace}/dspace-solr:${DSPACE_VER:-dspace-10_x}"
9595
networks:
9696
- dspacenet
9797
ports:

docker/docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ services:
2727
DSPACE_REST_HOST: ${DSPACE_REST_HOST:-localhost}
2828
DSPACE_REST_PORT: ${DSPACE_REST_PORT:-8080}
2929
DSPACE_REST_NAMESPACE: ${DSPACE_REST_NAMESPACE:-/server}
30-
image: "${DOCKER_REGISTRY:-docker.io}/${DOCKER_OWNER:-dspace}/dspace-angular:${DSPACE_VER:-latest}"
30+
image: "${DOCKER_REGISTRY:-docker.io}/${DOCKER_OWNER:-dspace}/dspace-angular:${DSPACE_VER:-dspace-10_x}"
3131
build:
3232
context: ..
3333
dockerfile: Dockerfile

0 commit comments

Comments
 (0)