Updated SubmitNewItemMenuProvider in order to depend on the showSubmitButton configuration.

Author: EikLoe

src/app/shared/menu/providers/submit-new-item.menu.spec.ts

@@ -1,9 +1,14 @@
 import { TestBed } from '@angular/core/testing';
+import { APP_CONFIG } from '@dspace/config/app-config.interface';
 import { AuthorizationDataService } from '@dspace/core/data/feature-authorization/authorization-data.service';
 import { Collection } from '@dspace/core/shared/collection.model';
 import { COLLECTION } from '@dspace/core/shared/collection.resource-type';
-import { of } from 'rxjs';
+import {
+  Observable,
+  of,
+} from 'rxjs';
 
+import { environment } from '../../../../environments/environment';
 import { MenuItemType } from '../menu-item-type.model';
 import { PartialMenuSection } from '../menu-provider.model';
 import { SubmitNewItemMenuProvider } from './submit-new-item.menu';
@@ -34,7 +39,7 @@ describe('SubmitNewItemMenuProvider', () => {
   });
 
 
-  let authorizationService;
+  let authorizationService: { isAuthorized: Observable<boolean> ; };
 
   beforeEach(() => {
 
@@ -46,6 +51,7 @@ describe('SubmitNewItemMenuProvider', () => {
       providers: [
         SubmitNewItemMenuProvider,
         { provide: AuthorizationDataService, useValue: authorizationService },
+        { provide: APP_CONFIG, useValue: environment },
       ],
     });
     provider = TestBed.inject(SubmitNewItemMenuProvider);
@@ -62,6 +68,12 @@ describe('SubmitNewItemMenuProvider', () => {
         done();
       });
     });
-  });
 
+    it('should set visibility depending on authorization and collection.showSubmitButton', done => {
+      provider.getSectionsForContext(dso).subscribe((sections) => {
+        expect(sections[0].visible).toEqual(authorizationService.isAuthorized && !environment.collection.showSubmitButton);
+        done();
+      });
+    });
+  });
 });

src/app/shared/menu/providers/submit-new-item.menu.ts

@@ -5,7 +5,14 @@
  *
  * http://www.dspace.org/license/
  */
-import { Injectable } from '@angular/core';
+import {
+  Inject,
+  Injectable,
+} from '@angular/core';
+import {
+  APP_CONFIG,
+  AppConfig,
+} from '@dspace/config/app-config.interface';
 import { AuthorizationDataService } from '@dspace/core/data/feature-authorization/authorization-data.service';
 import { FeatureID } from '@dspace/core/data/feature-authorization/feature-id';
 import { DSpaceObject } from '@dspace/core/shared/dspace-object.model';
@@ -27,6 +34,7 @@ import { DSpaceObjectPageMenuProvider } from './helper-providers/dso.menu';
 export class SubmitNewItemMenuProvider extends DSpaceObjectPageMenuProvider {
   constructor(
     protected authorizationDataService: AuthorizationDataService,
+    @Inject(APP_CONFIG) protected appConfig: AppConfig,
   ) {
     super();
   }
@@ -38,7 +46,7 @@ export class SubmitNewItemMenuProvider extends DSpaceObjectPageMenuProvider {
       map(([canSubmitItem]) => {
         return [
           {
-            visible: canSubmitItem,
+            visible: canSubmitItem && !this.appConfig.collection.showSubmitButton,
             model: {
               type: MenuItemType.LINK,
               text: 'collection.submit.item',