Allow configurable file size standard (SI, JEDEC, or IEC) in FileSizePipe

[MMilosz]

Is your feature request related to a problem? Please describe.

Currently, the FileSizePipe uses a hard-coded binary standard (JEDEC) for formatting file sizes. Changing the standard requires modifying the source code.

For comparison between different standards, look at ss below:

SI

1 MB = 1000 kB

JEDEC

1 MB = 1024 KB

IEC

1 MiB = 1024 KiB

Describe the solution you'd like

Make file size format configurable.

Here's where it can be found:

dspace-angular/src/app/shared/utils/file-size-pipe.ts

Lines 20 to 23 in aadea29

	export class FileSizePipe implements PipeTransform {
	transform(bytes: number = 0, precision: number = 2): string {
	return filesize(bytes, { standard: 'jedec', round: precision });
	}

Describe alternatives or workarounds you've considered

—

Additional information

• DSpace 7-SNAPSHOT introduced IEC units but switched to JEDEC before release FileSizePipe refactor #698
• This issue was inspired by testing Enhance FileSizePipe to support localization #5055 that adds localization for FileSizePipe

[mwoodiupui]

Does anyone need this to be configurable, or do we just need to get the system right? Only storage manufacturers use SI power-of-ten decades for storage sizes, which is for some reason appropriate to the products they make but not appropriate for the storage blocks that they implement. JEDEC power-of-two decades are traditional and well-understood by everyone except storage manufacturers, but confusingly use the same prefixes as SI for their slightly-larger decades. IEC power-of-two decades are also correct for multiples of storage blocks, but use their own vaguely unsettling yet distinct and unambiguous prefixes. Since we're talking about blocks rather than devices here, we probably ought to go back to IEC sizes for clarity and correctness even if "MiB" looks odd.

[tdonohue]

This seems like something we'd need to gather more information on. Is there really an expectation from some sites that we use the "SI" standard instead of our default "JEDEC" standard? If so, I'm OK with making this configurable. But, it has an unclear use case to me.

[tinsch]

To me the JEDEC Format looks weird and confusing. I stumbled upon this issue when one of our users asked about a differing file size on their computer (37,6MB) and on DSpace (35,87MB) and asked if the files were compressed by DSpace. Every system I know displays MB (SI units) or MiB, but never MiB disguised as MB. I'd be ok with displaying IEC per default, but would prefer SI since it is well understood by users. I believe only Windows uses the JEDEC standard?

Edit: Please excuse my bluntness here. Maybe I am just so used to unix systems using SI units since several years, and don't see the other perspective?

In the backend we had a similar issue: DSpace/DSpace#6726