Skip to content

Unit test redirectToEditItem is flaky #5553

Description

@lgeggleston

Describe the bug

The redirectToEditItem test in the submission service test suite has been especially flaky, sometimes failing multiple times in a row on the same code before succeeding.

FAILED TESTS:
  SubmissionService test suite
    redirectToEditItem
      ✖ should redirect to Item page
        Chrome Headless 147.0.0.0 (Linux x86_64)
      Error: <spyOn> : findById has already been spied upon
      Usage: spyOn(<object>, <methodName>)
      Error: <spyOn> : findById has already been spied upon
      Usage: spyOn(<object>, <methodName>)
          at <Jasmine>
          at UserContext.apply (src/app/submission/submission.service.spec.ts:1006:7)
          at UserContext.apply (node_modules/zone.js/fesm2015/zone-testing.js:1715:26)
          at _ZoneDelegate.invoke (node_modules/zone.js/fesm2015/zone.js:398:28)
          at ProxyZoneSpec.onInvoke (node_modules/zone.js/fesm2015/zone-testing.js:2132:39)
          at _ZoneDelegate.invoke (node_modules/zone.js/fesm2015/zone.js:397:34)
          at ZoneImpl.run (node_modules/zone.js/fesm2015/zone.js:113:43)
          at runInTestZone (node_modules/zone.js/fesm2015/zone-testing.js:216:38)

To Reproduce

It can be observed on various recent PR test runs. Example

Expected behavior

It would be best to re-evaluate this test to see if anything could make it less flaky, or whether it would make sense to disable the test entirely.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

bugclaimed: AtmireAtmire team is working on this issue & will contribute backtesting frameworkRelated specifically to Unit or Integration (e2e) Tests

Type

Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions