-
Notifications
You must be signed in to change notification settings - Fork 566
Allow input of alternative text for collection and community logos/th… #3389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DanGastardelli
wants to merge
34
commits into
DSpace:main
Choose a base branch
from
DanGastardelli:UpdatingAlternativeTextInThumbnails
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
07d489b
Allow input of alternative text for collection and community logos/th…
DanGastardelli cc74739
Checking for thumbnail with valid value
DanGastardelli 3fe8375
Merge branch 'main' into UpdatingAlternativeTextInThumbnails
DanGastardelli 0ab24be
Fixed merge done in git
DanGastardelli 296d4fb
Merge branch 'main' into UpdatingAlternativeTextInThumbnails
DanGastardelli 909aa99
Space correction
DanGastardelli cb75276
Space correction
DanGastardelli c78b775
Space correction
DanGastardelli 5affeb1
Merge branch 'UpdatingAlternativeTextInThumbnails' of https://github.…
DanGastardelli a90c02c
Space correction
DanGastardelli b140ca0
Merge branch 'main' into UpdatingAlternativeTextInThumbnails
DanGastardelli 0254f3d
Merge branch 'main' into UpdatingAlternativeTextInThumbnails
DanGastardelli 3ed8b29
Merge branch 'main' into UpdatingAlternativeTextInThumbnails
DanGastardelli cc0bbc8
Update es.json5
DanGastardelli daa04ca
Update es.json5
DanGastardelli 2e58674
Update es.json5
DanGastardelli 837d5c0
Merge branch 'main' into UpdatingAlternativeTextInThumbnails
DanGastardelli 3c9002b
Update es.json5
DanGastardelli 041a243
Merge branch 'main' into UpdatingAlternativeTextInThumbnails
DanGastardelli d7716ac
Merge branch 'main' into UpdatingAlternativeTextInThumbnails
DanGastardelli a1e206a
Merge branch 'main' into UpdatingAlternativeTextInThumbnails
DanGastardelli b364abc
Update pt-PT.json5
DanGastardelli 800349e
Update thumbnail.component.html
DanGastardelli 5b94a64
Merge branch 'main' into UpdatingAlternativeTextInThumbnails
DanGastardelli 94547fb
Update pt-PT.json5
DanGastardelli 32f95b3
Updating 'thumbnail.component.html'
DanGastardelli 8bd7a43
Update thumbnail.component.html
DanGastardelli a32bd05
Update thumbnail.component.html
DanGastardelli e41f1ac
Test setup for implementing custom thumbnail alt text
DanGastardelli b60f9ea
Update 'thumbnail.component.spec.ts'
DanGastardelli e8d71ae
Code simplification and preventative adjustments
DanGastardelli 539bd40
Optimizing code
DanGastardelli 48fb32c
Merge branch 'main' into UpdatingAlternativeTextInThumbnails
DanGastardelli af2852b
Merge branch 'main' into UpdatingAlternativeTextInThumbnails
DanGastardelli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was suggested in today's meeting that the more appropriate place to store the "alt" text for a Bitstream would be on the Bitstream object itself in the
dc.descriptionfield. This has two main benefits:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @tdonohue's comment here