Skip to content

Contribute to adding Persian translation to DSpace - #4453

Merged
tdonohue merged 16 commits into
DSpace:mainfrom
sh-habibi:main
Aug 4, 2025
Merged

Contribute to adding Persian translation to DSpace#4453
tdonohue merged 16 commits into
DSpace:mainfrom
sh-habibi:main

Conversation

@sh-habibi

Copy link
Copy Markdown
Contributor

Contribute to adding Persian translation to DSpace
fa.json5

@tdonohue tdonohue added i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge labels Jun 12, 2025
@tdonohue tdonohue moved this to 📋 To Do in DSpace 10.0 Release Jun 12, 2025
@tdonohue tdonohue moved this from 📋 To Do to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Jun 12, 2025
@tdonohue tdonohue added the port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release label Jun 12, 2025
@tdonohue tdonohue added this to the 10.0 milestone Jun 12, 2025
@nimabehforouz

Copy link
Copy Markdown
Contributor

Hello @sh-habibi. Thank you for initiating this! I had started working on this file some time ago and would be happy to contribute. @tdonohue Would it be possible to be added as the second assignee?

@tdonohue

tdonohue commented Aug 4, 2025

Copy link
Copy Markdown
Member

@nimabehforouz : There's no way on my end to allow two people to work on the same Pull Request. It's only possible for the owner of the pull request to accept contributions. But it's not very straightforward, as you'd have to send a PR to @sh-habibi 's repository with the changes you want to add.

The easier route is to merge this PR and then have you create a follow-up PR with additional changes. I've just updated this PR to get it ready for merger. I hope to merge it later today assuming the automated tests pass.

@tdonohue tdonohue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @sh-habibi ! This looks good to me.

@github-project-automation github-project-automation Bot moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace 10.0 Release Aug 4, 2025
@tdonohue
tdonohue merged commit eaf11d5 into DSpace:main Aug 4, 2025
15 checks passed
@github-project-automation github-project-automation Bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release Aug 4, 2025
@dspace-bot

Copy link
Copy Markdown
Contributor

Successfully created backport PR for dspace-9_x:

@tdonohue tdonohue removed the port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release label Aug 4, 2025
@sh-habibi

Copy link
Copy Markdown
Contributor Author

👍 Thanks @sh-habibi ! This looks good to me.

Thanks @tdonohue

Hello @sh-habibi. Thank you for initiating this! I had started working on this file some time ago and would be happy to contribute. @tdonohue Would it be possible to be added as the second assignee?

Hello @nimabehforouz, I am very happy that you are also working on the Persian translation. I hope that with the completion of the translation, more Iranian users will use this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants