Add custom input for page number in pagination - #4567
Draft
AndreaBarbasso wants to merge 5 commits into
Draft
Conversation
|
Hello! I tried out your patch and I noticed a few things:
I hope this helps. Thank you! |
|
Hi @AndreaBarbasso, |
# Conflicts: # src/app/shared/pagination/pagination.component.spec.ts
|
Hi @AndreaBarbasso, |
4science-it
pushed a commit
to 4Science/dspace-angular
that referenced
this pull request
Jun 19, 2026
Revert "[DSC-2618] hide downloads and view badges in collection" Approved-by: Andrea Barbasso
added 2 commits
August 12, 2026 13:09
…URACOM-386_aligned # Conflicts: # src/app/shared/pagination/pagination.component.ts
Contributor
Author
|
I aligned this branch to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Created a new property in order to show an
inputfield on the pagination component. The input accepts a number to go to the related page, falling back to the first or last page if the given input is out of boundaries.Instructions for Reviewers
There is no configuration setting to enable this behavior right now (discussion is ongoing in #4566), so the only way to test it is either by setting
trueas the default value forenablePaginationInputor by passing atruevalue as a component input.Then, the input should be visible and work as expected.
List of changes in this PR:
inputChecklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.