Skip to content

Update @types/node to ^18.11.9 - #4622

Merged
tdonohue merged 1 commit into
DSpace:mainfrom
alanorth:node-types
Aug 5, 2025
Merged

Update @types/node to ^18.11.9#4622
tdonohue merged 1 commit into
DSpace:mainfrom
alanorth:node-types

Conversation

@alanorth

@alanorth alanorth commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

Description

As of DSpace 10.0-SNAPSHOT we currently support Node.js v18 and v20 so we should—in theory—be using appropriate types.

Also note that, as of this writing, Node.js v20 and v22 are the currently supported LTS versions of Node.js. We should bump our versions.

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

  • First, update @types/node from ^14.14.9 to ^18.11.9.

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Make sure the application builds and TypeScript-aware editors like VS Code still show syntax highlighting and type annotations.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

As of DSpace 10.0-SNAPSHOT we currently support Node.js v18 and v20
so we should be using appropriate types.
@alanorth alanorth added dependencies Pull requests that update a dependency file 1 APPROVAL pull request only requires a single approval to merge labels Aug 5, 2025
@alanorth alanorth added this to the 10.0 milestone Aug 5, 2025
@tdonohue tdonohue moved this to 👀 Under Review in DSpace 10.0 Release Aug 5, 2025
@tdonohue tdonohue added the port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release label Aug 5, 2025

@tdonohue tdonohue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @alanorth ! I agree with this..didn't realize our @types/node was so outdated. I've also flagged this to port to dspace-9_x as it can be easily backported to that release (as it also uses package-lock.json)

@github-project-automation github-project-automation Bot moved this from 👀 Under Review to 👍 Reviewer Approved in DSpace 10.0 Release Aug 5, 2025
@tdonohue
tdonohue merged commit 18aafea into DSpace:main Aug 5, 2025
15 checks passed
@github-project-automation github-project-automation Bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release Aug 5, 2025
@dspace-bot

Copy link
Copy Markdown
Contributor

Successfully created backport PR for dspace-9_x:

@alexandrevryghem alexandrevryghem removed the port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release label Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge dependencies Pull requests that update a dependency file

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants