Fix untranslated i18n keys ror api - #4628
Merged
tdonohue merged 3 commits intoSep 3, 2025
Merged
Conversation
tdonohue
approved these changes
Sep 3, 2025
tdonohue
left a comment
Member
There was a problem hiding this comment.
👍 Thanks @jesielviana ! Tested this alongside DSpace/DSpace#11041 and it looks good
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-8_x
git worktree add -d .worktree/backport-4628-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-4628-to-dspace-8_x
git switch --create backport-4628-to-dspace-8_x
git cherry-pick -x b6bf86254293f8492c4fe1345fd77ad7cef805e8 14de56279faf2573768393efb38e666101a17274 22baef689a82ddb0e6308beb4d4aa9f535dc8ebf |
Contributor
|
Successfully created backport PR for |
4science-it
pushed a commit
to 4Science/dspace-angular
that referenced
this pull request
Jul 17, 2026
Task/dspace cris 2025 02 x/DSC-1504 Approved-by: Francesco Molinaro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Added missing i18n keys from the ROR API to the en.json5 and pt-BR.json5 files.
Instructions for Reviewers
Trigger an ROR import and check whether the labels display correctly in both English and Brazilian Portuguese.
List of changes in this PR:
en.json5pt-BR.json5Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.