Skip to content

Fix untranslated i18n keys ror api - #4628

Merged
tdonohue merged 3 commits into
DSpace:mainfrom
LA-Referencia-Lyrasis-Project:fix-untranslated-i18n-keys-ror-api
Sep 3, 2025
Merged

Fix untranslated i18n keys ror api#4628
tdonohue merged 3 commits into
DSpace:mainfrom
LA-Referencia-Lyrasis-Project:fix-untranslated-i18n-keys-ror-api

Conversation

@jesielviana

Copy link
Copy Markdown
Contributor

References

Description

Added missing i18n keys from the ROR API to the en.json5 and pt-BR.json5 files.

Instructions for Reviewers

Trigger an ROR import and check whether the labels display correctly in both English and Brazilian Portuguese.

List of changes in this PR:

  • Added missing ROR API i18n keys to en.json5
  • Added missing ROR API i18n keys to pt-BR.json5

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added 1 APPROVAL pull request only requires a single approval to merge tools:import-sources Related to "Live Import" Sources feature, allowing import of content via external APIs. port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Sep 3, 2025
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Sep 3, 2025

@tdonohue tdonohue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @jesielviana ! Tested this alongside DSpace/DSpace#11041 and it looks good

@github-project-automation github-project-automation Bot moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace 10.0 Release Sep 3, 2025
@tdonohue tdonohue added this to the 10.0 milestone Sep 3, 2025
@tdonohue
tdonohue merged commit 7c8486a into DSpace:main Sep 3, 2025
15 checks passed
@github-project-automation github-project-automation Bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release Sep 3, 2025
@dspace-bot

Copy link
Copy Markdown
Contributor

Backport failed for dspace-8_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-8_x
git worktree add -d .worktree/backport-4628-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-4628-to-dspace-8_x
git switch --create backport-4628-to-dspace-8_x
git cherry-pick -x b6bf86254293f8492c4fe1345fd77ad7cef805e8 14de56279faf2573768393efb38e666101a17274 22baef689a82ddb0e6308beb4d4aa9f535dc8ebf

@dspace-bot

Copy link
Copy Markdown
Contributor

Successfully created backport PR for dspace-9_x:

@tdonohue tdonohue removed port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Sep 3, 2025
4science-it pushed a commit to 4Science/dspace-angular that referenced this pull request Jul 17, 2026
Task/dspace cris 2025 02 x/DSC-1504

Approved-by: Francesco Molinaro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge tools:import-sources Related to "Live Import" Sources feature, allowing import of content via external APIs.

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants