Skip to content

Replace plaintext links to www.dspace.org - #4633

Merged
tdonohue merged 3 commits into
DSpace:mainfrom
alanorth:dspace.org-http-links
Aug 28, 2025
Merged

Replace plaintext links to www.dspace.org#4633
tdonohue merged 3 commits into
DSpace:mainfrom
alanorth:dspace.org-http-links

Conversation

@alanorth

@alanorth alanorth commented Aug 9, 2025

Copy link
Copy Markdown
Contributor

Description

We have many occurrences of plaintext HTTP links to www.dspace.org in the UI and license notices. In 2025 we should not be using plaintext links anywhere, and www.dspace.org even returns an HTTP 301 permanent redirect to the HTTPS version.

I used this command to find and replace all occurrences:

$ grep -rl 'http://www.dspace.org' * \
  | xargs sed -i 's_http://www.dspace.org_https://www.dspace.org_'

We should do the same on all other currently supported branches but the pull requests will need to be manual.

Instructions for Reviewers

Make sure the frontend still builds and runs.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@alanorth alanorth added code task low priority documentation Ticket describes improvements or additions to documentation labels Aug 9, 2025

@tdonohue tdonohue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alanorth : Overall, I'm in favor of the minor cleanup. But, I'm honestly hesitant to modify our DSpace license header as that is in every single Java file on the backend. So, if we modify it here, we likely need to modify every backend file.

See comment inline below

Comment thread docker/cli.assetstore.yml
@tdonohue tdonohue added this to the 10.0 milestone Aug 20, 2025
@tdonohue tdonohue moved this to 👀 Under Review in DSpace 10.0 Release Aug 20, 2025
@alanorth
alanorth force-pushed the dspace.org-http-links branch from 175e3a7 to 0bdb8ec Compare August 26, 2025 06:38
@alanorth

Copy link
Copy Markdown
Contributor Author

Hi @tdonohue, I've adjusted this to only modify links in README.md and the footer.

@tdonohue tdonohue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alanorth ! Overall, this looks good now. But, I found one broken link that we should correct before merging.

Comment thread README.md Outdated

@tdonohue tdonohue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @alanorth ! Looks good now.

@github-project-automation github-project-automation Bot moved this from 👀 Under Review to 👍 Reviewer Approved in DSpace 10.0 Release Aug 28, 2025
@tdonohue
tdonohue merged commit 20cef9c into DSpace:main Aug 28, 2025
15 checks passed
@github-project-automation github-project-automation Bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release Aug 28, 2025
@alanorth
alanorth deleted the dspace.org-http-links branch August 29, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code task documentation Ticket describes improvements or additions to documentation low priority

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants