Replace plaintext links to www.dspace.org - #4633
Merged
Merged
Conversation
tdonohue
reviewed
Aug 20, 2025
tdonohue
left a comment
Member
There was a problem hiding this comment.
@alanorth : Overall, I'm in favor of the minor cleanup. But, I'm honestly hesitant to modify our DSpace license header as that is in every single Java file on the backend. So, if we modify it here, we likely need to modify every backend file.
See comment inline below
alanorth
force-pushed
the
dspace.org-http-links
branch
from
August 26, 2025 06:38
175e3a7 to
0bdb8ec
Compare
Contributor
Author
|
Hi @tdonohue, I've adjusted this to only modify links in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have many occurrences of plaintext HTTP links to www.dspace.org in the UI and license notices. In 2025 we should not be using plaintext links anywhere, and www.dspace.org even returns an HTTP 301 permanent redirect to the HTTPS version.
I used this command to find and replace all occurrences:
We should do the same on all other currently supported branches but the pull requests will need to be manual.
Instructions for Reviewers
Make sure the frontend still builds and runs.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.