Skip to content

Client side rendering (CSR) ignores nameSpace configuration causing broken resource loading - #4638

Merged
tdonohue merged 1 commit into
DSpace:dspace-7_xfrom
dataquest-dev:csr-namespace-rendering
Oct 13, 2025
Merged

Client side rendering (CSR) ignores nameSpace configuration causing broken resource loading#4638
tdonohue merged 1 commit into
DSpace:dspace-7_xfrom
dataquest-dev:csr-namespace-rendering

Conversation

@milanmajchrak

Copy link
Copy Markdown
Contributor

References

Description

Fix CSR ignoring namespace configuration, causing broken resource loading when DSpace is deployed with a custom namespace (e.g., /repository).

Instructions for Reviewers

List of changes in this PR:

  1. Modified clientSideRender() function to dynamically replace base href with namespace configuration
  2. Added REST URL replacement logic to CSR for consistency with SSR behavior

How to test:

  1. Configure DSpace with ui.nameSpace: /repository
  2. Exclude SSR for the ^/search$" page
  3. Go to the /repository/search and refresh the page

Expected behaviour:

  • The search page has loaded correctly; you are not seeing a blank page

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@bkeese

bkeese commented Aug 12, 2025

Copy link
Copy Markdown

+1 This fixes the same problem in our 7.6.5 instances.

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge port to dspace-7_x port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Aug 20, 2025
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Aug 20, 2025
@tdonohue tdonohue removed port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Aug 20, 2025
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace Maintenance (10.x, 9.x, 8.x) Aug 20, 2025
@tdonohue tdonohue added port to main This PR needs to be ported to `main` branch for the next major release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release and removed port to dspace-7_x labels Aug 20, 2025
@tdonohue tdonohue linked an issue Aug 21, 2025 that may be closed by this pull request
@tdonohue tdonohue moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace 10.0 Release Aug 27, 2025
@tdonohue tdonohue changed the title CSR ignores namespace configuration causing broken resource loading Client side rendering (CSR) ignores nameSpace configuration causing broken resource loading Sep 8, 2025

@tdonohue tdonohue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @milanmajchrak ! I was able to verify the bug also exists on main, and was able to verify this PR fixes the issues.

Merging this into 7.x and auto-porting to all other active branches.

@tdonohue
tdonohue merged commit aea7e7b into DSpace:dspace-7_x Oct 13, 2025
23 of 27 checks passed
@github-project-automation github-project-automation Bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release Oct 13, 2025
@dspace-bot

Copy link
Copy Markdown
Contributor

@dspace-bot

Copy link
Copy Markdown
Contributor

@dspace-bot

Copy link
Copy Markdown
Contributor

@tdonohue tdonohue removed port to main This PR needs to be ported to `main` branch for the next major release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Oct 13, 2025
@tdonohue tdonohue added this to the 7.6.6 milestone Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug

Projects

Development

Successfully merging this pull request may close these issues.

CSR ignores namespace configuration causing broken resource loading

4 participants