fix: call parent ngOnDestroy in dynamic form control container

[jlipka]

References

Fixes #4645

Description

The 'DsDynamicFormControlContainerComponent' extends the 'DynamicFormControlContainerComponent', which comes from a third-party library (ng-dynamic-forms). When navigating away from a form that uses this component, any existing subscriptions are now removed and the default behavior of the lifecycle method "ngOnDestroy" is triggered again.

Instructions for Reviewers

I took memory snapshots using Firefox after navigation into a submission, click "save for later" and reopen it and looped this sequence about 10 times. The screenshot is probably not highly scientific, but it shows that there are significantly more objects and arrays in memory:

If you know of a way to illustrate the effects even better, I would be grateful if you could let me know.

Checklist

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[tdonohue]

👍 Thanks @jlipka ! I'm able to reproduce the memory differences locally, though it's not as significant. Nonetheless, it looks to be beneficial to me as well and the code change is quite simple!

[dspace-bot]

Successfully created backport PR for dspace-7_x:

• [Port dspace-7_x] fix: call parent ngOnDestroy in dynamic form control container #4707

[dspace-bot]

Successfully created backport PR for dspace-8_x:

• [Port dspace-8_x] fix: call parent ngOnDestroy in dynamic form control container #4708

[dspace-bot]

Successfully created backport PR for dspace-9_x:

• [Port dspace-9_x] fix: call parent ngOnDestroy in dynamic form control container #4709