Fix against the bitstream format cannot be specified during the submi…

[im-shivamb]

References

• Fixes The bitstream format cannot be specified during the submission #2106

Description

In previous DSpace versions, after uploading a bitstream, users could manually update its format. This is important when the uploaded file format is not recognized in the DSpace format registry. Currently, the UI does not allow selecting or describing a custom format during new Item submission.

Instructions for Reviewers

To review this PR, start a new item submission and upload a file. Then, click on Edit Bitstream against the uploaded file. You should now see a drop down list of available bitstream formats. Either selecting from a known format list or selecting the option Format not in list, an additional input box labelled Describe New Format should appear, which allows to type a custom format description. On clicking on Save it should get updated against the uploaded bitstream.

List of changes in this PR:

• Modified section-upload-file-edit.component.ts to render a drop down from existing bitstream format list, if format is unknown, an additional input box labelled Describe New Format appears. Saving should correctly update the bitstream with either the chosen format or the custom entered description.
• Updated section-upload-file-edit.component.spec.ts with new test cases against the existing bitstream format list rendering in the drop down , and conditional input field Describe New Format visibility in case Format not in list selected. Updates the specified format against the selected bitstream.

Guidance for how to test or review this PR:

1. Login with any user with upload privileges.
2. Start creating a new item from the submission flow.
3. Upload a file.
4. Click on Edit bitstream icon against the uploaded file.
5. At the end of the Edit bitstream modal Selected format drop down will be visible. Where user can select any of the known formats or can select Format not in list where new input field Describe New Format will appear. Here user can specify own custom format.
6. On clicking on Save it will update the provided format against the bitstream.

[github-actions]

Hi @im-shivamb,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

[github-actions]

Hi @im-shivamb,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

[github-actions]

Hi @im-shivamb,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

[tdonohue]

@im-shivamb : Apologies that we have not gotten a reviewer on this PR yet. However, we are just beginning a more detailed review process for 10.0 for all new feature PRs. If you can rebase this on latest main (to resolve the merge conflicts) that would allow us to consider this for 10.0. Thanks!

[jlipka]

Tested this change and it works.

A little side note: After selecting "Format not in list", the value inside the select box becomes "Unknown". If you click again onto the select box, i would expect the "Format not in list" entry to be selected - but it is not. Not a blocker for me, but not consistent with the default behaviour.

[lgeggleston]

@im-shivamb General reminder for all new feature PRs currently under review: there is still a possibility of getting this into 10.0, in case you are able to address the tester's comment. Feature merge deadline will be Friday 3/27. Thank you!

[tdonohue]

Unfortunately, this Feature PR missed our DSpace 10.0 "Feature PR Merge Deadline". As DSpace 10.0 is now under a "Feature Freeze", this ticket will be moved to our 11.0 release board in the hopes of completing this feature in the next release. If there are any questions, let us know.

[github-actions]

Hi @im-shivamb,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!