[Port dspace-8_x] src/themes/dspace: rework banner image - #4715
Merged
Conversation
For some reason our version of this image is twice the size of the original (~860KiB vs 1.6MiB). To make matters worse, the dimensions of the image are 4777x3166 pixels, but we display it at 2000 pixels wide. This regenerates the images based on the original and adjusts the dimensions to be more appropriate. Generated using ImageMagick 7 on Linux: $ magick pexels-inspiredimages-132477.jpg -resize 2000x src/themes/dspace/assets/images/banner.jpg $ magick pexels-inspiredimages-132477.jpg -resize 2000x src/themes/dspace/assets/images/banner.webp $ magick pexels-inspiredimages-132477.jpg -resize 1200x src/themes/dspace/assets/images/banner-half.jpg $ magick pexels-inspiredimages-132477.jpg -resize 1200x src/themes/dspace/assets/images/banner-half.webp See: https://www.pexels.com/photo/clear-water-drops-132477/ (cherry picked from commit d9e8fea)
dspace-bot
added
1 APPROVAL
12 tasks
github-project-automation
Bot
moved this to ✅ Done
in DSpace Maintenance (10.x, 9.x, 8.x)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #4636 by @alanorth to
dspace-8_x.