Skip to content

Add browse definition handling in BrowseByDateComponent - #5121

Closed
xvThomas wants to merge 1 commit into
DSpace:mainfrom
xvThomas:xvThomas/issue5120
Closed

Add browse definition handling in BrowseByDateComponent#5121
xvThomas wants to merge 1 commit into
DSpace:mainfrom
xvThomas:xvThomas/issue5120

Conversation

@xvThomas

@xvThomas xvThomas commented Feb 17, 2026

Copy link
Copy Markdown

Fixes #5122

@tdonohue

tdonohue commented Feb 17, 2026

Copy link
Copy Markdown
Member

@xvThomas : Thanks for this PR. Just a few notes:

  1. This PR has a merge conflict with our main branch. Could you clean that up please so that automated tests are able to run? You may need to rebase this PR against the latest main code, or similar.
  2. Also, it'd be good to provide details to others about how to test this PR. As all our reviewers/testers are volunteers, it can help to find volunteers if you can describe (in the PR description) the steps to take to verify that the PR is working properly. That's why we provide a PR template that we ask everyone to fill out. So, if you have time, I think it'd also be useful to add testing steps to the description.

@tdonohue tdonohue added bug component: Discovery related to discovery search or browse system 1 APPROVAL pull request only requires a single approval to merge labels Feb 17, 2026
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Feb 17, 2026
@xvThomas

Copy link
Copy Markdown
Author

Hello @tdonohue,

My apologies, I now remember that I created the PR from the 9_x branch, not the main branch. The last commit for 9_x was 3 months ago. In the meantime, there have been several commits to the main branch. That is why there is a conflict.

It would be best to check if the newer code in the main branch resolves the issue (MR/commit: a9a9e97). That would make my PR obsolete.

I can do that on my end and will keep you posted.

So my question is: if the latest commit resolves the issue, how and when can we get a stable (released) version (9_x?) that includes commit a9a9e97?

Regards

@tdonohue

Copy link
Copy Markdown
Member

@xvThomas : If you find this has been fixed on main, then you (or someone else) could always backport the fix to dspace-9_x by creating a new PR against the dspace-9_x branch.

However, if it's not fixed on main, then I recommend creating a PR against the main branch to fix the issue, and we can attempt to auto-backport it to dspace-9_x and other branches.

In general, for bug fixes, we do our best to always backport them to at least dspace-9_x...but sometimes we make mistakes or don't realize that a specific bug impacts older releases as well.

@tdonohue

Copy link
Copy Markdown
Member

@xvThomas : Digging a bit deeper, it looks like this PR includes the commit you referenced: #3741.

Unfortunately, that PR is still waiting on a backport to dspace-9_x, dspace-8_x and dspace-7_x. See this comment. I'll ping that developer again on that #3741 PR to see if they can provide a backport.

@github-actions

Copy link
Copy Markdown

Hi @xvThomas,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace 11.0 Release Jun 2, 2026
@tdonohue

tdonohue commented Aug 5, 2026

Copy link
Copy Markdown
Member

Closing, as this is replaced by #6069, which is a 9.x backport of #3741 (which fixed this same issue on main). This issue should therefore now be fixed on the dspace-9_x branch.

@tdonohue tdonohue closed this Aug 5, 2026
@github-project-automation github-project-automation Bot moved this from 🙋 Needs Reviewers Assigned to ✅ Done in DSpace 11.0 Release Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug component: Discovery related to discovery search or browse system merge conflict

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

browse-by-date-component is using a wrong item metadata

3 participants