Fix #5331: update system-wide alert preview countdown dynamically - #5383
Fix #5331: update system-wide alert preview countdown dynamically#5383guillermo-escire wants to merge 3 commits into
Conversation
|
@guillermo-escire pr_5383_converted.mp4 |
There was a problem hiding this comment.
@guillermo-escire
I've been testing it locally and it seems to not be working quite as expected on my side. I am not sure if I am missing a step, but when the timer drops below 1 minute, the countdown disappears completely from the preview banner instead of showing the remaining seconds.
I noticed @kanasznagyzoltan might have run into the exact same issue based on the video uploaded above. I've also attached a quick video below showing the behavior on my end.
Observation: I posted it as "Suggested change" but it's essencially a commentary, thanks for the hark work!
References
Fixes #5331
Description
Fixes the system-wide alert countdown timer in the preview. The countdown now updates dynamically every second and disappears when it reaches zero.
Instructions for Reviewers
Changes included in this PR:
How to test:
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.