Skip to content

Show Shared Submission menu even if user is not submitter - #5630

Merged
tdonohue merged 2 commits into
DSpace:mainfrom
4Science:task/main/DURACOM-476
May 20, 2026
Merged

Show Shared Submission menu even if user is not submitter#5630
tdonohue merged 2 commits into
DSpace:mainfrom
4Science:task/main/DURACOM-476

Conversation

@AdamF42

@AdamF42 AdamF42 commented May 6, 2026

Copy link
Copy Markdown
Contributor

References

Description

Simple update to show "Shared Submission" items menu even if user is not submitter.

How to test

  1. Log-in as simple author (the user should not be in any submission/admin group)
  2. Verify that in MyDSpace dashboard you should be able to see the "Shared submission" option

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@AdamF42 AdamF42 changed the title Show Other Workspace Items menu even if user is not submitter Show Shared Submission menu even if user is not submitter May 6, 2026
@AdamF42
AdamF42 marked this pull request as ready for review May 6, 2026 16:31
@tdonohue tdonohue added component: submission 1 APPROVAL pull request only requires a single approval to merge DSpace-CRIS merger This ticket/PR relates to the merger of DSpace-CRIS into DSpace. blocker This ticket or PR will block whatever release milestone is associated with it. labels May 6, 2026
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release May 6, 2026
@tdonohue
tdonohue self-requested a review May 6, 2026 20:07
@tdonohue tdonohue moved this from 🙋 Needs Reviewers Assigned to 👀 Under Review in DSpace 10.0 Release May 6, 2026

@tdonohue tdonohue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @AdamF42 ! Tested this with the backend. This small PR appears to be working, but I've found a few small issues on the backend that I'll report shortly.

I'll wait to merge this frontend PR until the backend is also working.

@github-project-automation github-project-automation Bot moved this from 👀 Under Review to 👍 Reviewer Approved in DSpace 10.0 Release May 12, 2026
@tdonohue tdonohue added this to the 10.0 milestone May 20, 2026
@tdonohue

Copy link
Copy Markdown
Member

Merging with +1 approval. Thanks again @AdamF42 !

@tdonohue
tdonohue merged commit 8498f55 into DSpace:main May 20, 2026
16 checks passed
@github-project-automation github-project-automation Bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge blocker This ticket or PR will block whatever release milestone is associated with it. component: submission DSpace-CRIS merger This ticket/PR relates to the merger of DSpace-CRIS into DSpace.

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants